-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Bluetooth state/permission changes correctly #6
Comments
So it seems that Bluetooth connection and interaction device works fine without location services or permission - it's only the Bluetooth scanning that requires location permissions and services to be enabled. That part is already handled properly by RxAndroidBle. Also, if location (or any other permission) is denied, Android will kill the app process, so we don't have to worry about handling that scenario. |
this all sounds like for recent versions of Android. I just hope you wont
drop older versions support. Thanks.
|
No, I'm not planning to drop support for the older versions. It's just that we need to also support the newer versions properly (e.g location permissions requirement). Anyway, I've finally raised the target SDK version to API 23 (Android 6.0 Marshmallow). Will raise it soon, all the way to API 29. |
Finished implementing as of 995951f |
Also, wanted to inform you that I've done all of my new work in a new branch here - https://github.com/sandy-8925/BLExplorer/tree/modernization_v2 I doubt I'll be able to merge this upstream, since I've made a huge number of changes and ligi hasn't reviewed that initial change yet. |
The text was updated successfully, but these errors were encountered: