Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Android Api Level 33 Supported #252

Closed
Nawanop-AMNB opened this issue Aug 15, 2022 · 12 comments
Closed

Request Android Api Level 33 Supported #252

Nawanop-AMNB opened this issue Aug 15, 2022 · 12 comments
Assignees

Comments

@Nawanop-AMNB
Copy link

Is your feature request related to a problem? Please describe.
Android 13 SDK (API level 33) does changing about image/video/audio access permission
In current version Permission.READ_EXTERNAL_STORAGE is deprecated and has been changed to 3 permissions below

Permission.READ_MEDIA_IMAGES
Permission.READ_MEDIA_VIDEO
Permission.READ_MEDIA_AUDIO

When start image picker on api 33. it will close the picker activity and Toast appear to tell me that Permission Denied
So image picker won't worked in api 33 (I have tested this already)

Describe the solution you'd like
Need support target api version 33

Additional context

@joseaviles-pro
Copy link

I'm also having this issue.

@sangcomz sangcomz self-assigned this Sep 15, 2022
@sangcomz
Copy link
Owner

got it. i will handle this issue.
thanks all!

@Nawanop
Copy link

Nawanop commented Sep 15, 2022

Thanks for considering my request 😁

@sangcomz
Copy link
Owner

Hi, @Nawanop, @joseaviles-pro I update sdk version. and I upload new library.
If you can test this, please test this. Thanks :)

add in project build.gradle

    repositories {
        maven {
            url "https://s01.oss.sonatype.org/content/repositories/snapshots/"
        }
    }

add in module build.gradle

    implementation 'io.github.sangcomz:fishbun:upgrade-sdk33-SNAPSHOT'

@mattserudolph
Copy link

Hi @sangcomz , I just tried the snapshot version and it works as expected. Thanks!

@Nawanop-AMNB
Copy link
Author

@sangcomz I haven't test yet maybe I will test on weekend. Thanks for working hard ;DD

@joseaviles-pro
Copy link

Hi @sangcomz , thanks for working on this. I've tested, it's working on Api Level 33 now, but stopped working for others Api Levels. Can you please take a look? Thank you.

@mattserudolph
Copy link

Ho @joseaviles-pro , I tried to reproduce your problems, but all the configurations below work for me:

I tested the SDK snapshot version with these configurations:

  • targetSdk: Api Level 33, Emulator: Api Level 33 --> Ok
  • targetSdk: 33, Emulator: 31 --> Ok
  • targetSdk: 31, Emulator: 33 --> Ok
  • targetSdk: 31, Emulator: 31 --> Ok

@joseaviles-pro
Copy link

Hi @mattserudolph, thank you for testing that. You're right! I was missing the WRITE_EXTERNAL_STORAGE permission in the Manifest. Now it's working for me in all Api Levels. @sangcomz, is this the final SDK version or are you planning to release another version for using in Production? Thank you.

@sangcomz
Copy link
Owner

sangcomz commented Oct 3, 2022

Hi, @mattserudolph @joseaviles-pro
Released version 1.1.0. Please use this version.
And let me know if your app is on the Play Store.
I would like to update this part.
https://github.com/sangcomz/FishBun#apps-using-fishbun

thanks!

@sangcomz sangcomz closed this as completed Oct 3, 2022
@mattserudolph
Copy link

Hi @sangcomz , thanks for publishing the update.
Our app is: https://play.google.com/store/apps/details?id=de.bkk_mobil_oil.mobilme&gl=DE
We're an health insurance company from Germany. The usage of your library is part of a document upload process which is only available for our registered customers.

@joseaviles-pro
Copy link

Hi @sangcomz, thank you. I'm testing the library in an app I'm developing. I'll let you know when I publish it on the Play Store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants