Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPL-556 Sample declarations multiple errors response include info #52

Closed
harrietc52 opened this issue Jul 3, 2020 · 0 comments · Fixed by #65
Closed

GPL-556 Sample declarations multiple errors response include info #52

harrietc52 opened this issue Jul 3, 2020 · 0 comments · Fixed by #65
Assignees
Labels
Enhancement New feature or request

Comments

@harrietc52
Copy link
Contributor

User story
As a developer we would like the 422 response of a samples_declarations POST, which contains multiple errors, to inlcude more information about the root_sample_id

Who are the primary contacts for this story
Eduardo
Harry

Acceptance criteria

[ { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020466", "value_in_sequencing": "No" }, { "declared_at": "2020-06-26T11:37:45", "value_in_sequencing": "No" }, { "declared_at": "2020-14-500", "root_sample_id": "YOR10020379", "value_in_sequencing": "No" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020240", "value_in_sequencing": "Yes" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020379", "value_in_sequencing": "Yes" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020224", "value_in_sequencing": "Yes" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020218", "value_in_sequencing": "Yes" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020217", "othertag": "othervalue" }, { "declared_at": "2020-06-26T11:37:45", "root_sample_id": "YOR10020195", "value_in_sequencing": "maybelater" } ]

The above json, with errors, will include the root_sample_id in the response for each respective error message

@harrietc52 harrietc52 added the Enhancement New feature or request label Jul 3, 2020
@rl15 rl15 changed the title GPL-nnn Sample declarations multiple errors response include info GPL-556 Sample declarations multiple errors response include info Jul 6, 2020
@harrietc52 harrietc52 self-assigned this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant