Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y24-101 Tube Rack Banking Transfer Requests #1698

Open
4 tasks
yoldas opened this issue May 20, 2024 · 3 comments
Open
4 tasks

Y24-101 Tube Rack Banking Transfer Requests #1698

yoldas opened this issue May 20, 2024 · 3 comments
Labels

Comments

@yoldas
Copy link
Member

yoldas commented May 20, 2024

User story
As PSD, we would like to support creation of transfer requests from Limber upon upload of tube rack scan files using the versioned tube rack model proposed in Reuse of TubeRacks document.

Who are the primary contacts for this story
Abdullah, Katy, Andrew

Who is the nominated tester for UAT
TBD

Acceptance criteria
To be considered successful the solution must allow:

  • LRC Bank Seq and LRC Bank Spare TubeRacks can be viewed in Sequencescape, with location, tubes, and samples.
  • LRC PBMC Bank plate is parent of LRC Bank Seq and LRC Bank Spare TubeRacks in Sequencescape.
  • LRC PBMC Bank wells are parents of LRC Bank Seq and LRC Bank Spare tubes in Sequencescape.
  • LRC PBMC Bank Children tab shows the LRC Bank Seq and LRC Bank Spare TubeRacks in Limber.

Dependencies
This story is blocked by the following dependencies:

References
This story has a non-blocking relationship with:

Additional context
The versioned tube rack model is researched in DPL-1011 Re-use of tube racks and the model is summarised in the Google Document DPL-1011 Re-use of tube racks

This story is part of re-implementation of DPL-811 Transfer PBMC isolations into FluidX tube racks (Banking) using the versioned tube rack model.

Story relationships are shown in the Lucidchart diagram TubeRack Stories .

A TubeRack looks like the following in Sequencescape: https://sequencescape.psd.sanger.ac.uk/labware/27083543

It is not possible to release the implementation of this story in isolation.

@yoldas yoldas changed the title Y24-091 Tube Rack Banking Transfer Requests Y24-083 Tube Rack Banking Transfer Requests May 20, 2024
@TWJW-SANGER
Copy link

I might suggest that the acceptance criteria is better phrased from the users point of view (if only for testing), so something like:
The user can see the link between source and destination tube on pages X,Y,Z
And maybe
The user can see the link between source and destination tube racks on pages X,Y,Z

Linking the objects/tables is needed but is not sufficient to meet the criteria above (as you may need UI / API changes too...)

@KatyTaylor
Copy link
Contributor

Agree with Tom that I generally prefer acceptance criteria from the user POV if poss. In this case though, I think the user-facing bit of transfer requests will be that the wells appear to be filled in / the plate state changes when the transfer requests are passed...

The parent child links seen in Sequencescape (and the children tab in Limber) are using a different model... asset links I think?

@yoldas yoldas changed the title Y24-083 Tube Rack Banking Transfer Requests Y24-100 Tube Rack Banking Transfer Requests May 21, 2024
@yoldas yoldas changed the title Y24-100 Tube Rack Banking Transfer Requests Y24-101 Tube Rack Banking Transfer Requests May 21, 2024
@yoldas
Copy link
Member Author

yoldas commented May 24, 2024

I have changed the criteria to focus on the relationships between the LRC PBMC Bank Plate and LRC Bank Seq and LRC Bank Spare TubeRacks, and wells and tubes. These relationships should be visible in Sequencescape if transfer requests are created correctly. In Limber, I have included only the LRC PBMC Bank Children tab for this story. I have also added a TubeRack page as an example in Sequencescape.

I have also added #1697 as dependency. The stories have some logical order, therefore it sets up transitive dependencies for this story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants