Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sessions and Calls should be destroyed in CHANNEL_DESTROY? #35

Open
goodboy opened this issue Mar 23, 2016 · 1 comment
Open

Sessions and Calls should be destroyed in CHANNEL_DESTROY? #35

goodboy opened this issue Mar 23, 2016 · 1 comment

Comments

@goodboy
Copy link
Contributor

goodboy commented Mar 23, 2016 •
edited
Loading

Not sure why (other then perf?) we aren't just destroying all Session and Call models in a CHANNEL_DESTROY event handler? It seems to always come after CHANNEL_HANGUP. This should also simplify the logic int he CDR app here such that we won't need to make temp bindings to sessions on the call instance.
@goodboy
Copy link
Contributor Author

goodboy commented Mar 23, 2016

Just plugged in a callback and ran the unit tests. Seems to be fine?
It'd be interesting to see the effects once we have proper benchmarking tests in place.

@goodboy goodboy mentioned this issue Oct 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goodboy