Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add CI for windows #160

Closed
AtomsForPeace opened this issue Jan 12, 2020 · 4 comments
Closed

[Feature Request] Add CI for windows #160

AtomsForPeace opened this issue Jan 12, 2020 · 4 comments
Labels

Comments

@AtomsForPeace
Copy link
Contributor

As mentioned in #155, we need to add tests for windows users regarding ujson and other differences.
Here is how sanic does it: https://github.com/huge-success/sanic/blob/784d5cce5234933a5af36b668c8ffce1af4af91a/tox.ini#L6-L8

@AtomsForPeace
Copy link
Contributor Author

When the test requirements are installed, the requirements of sanic are also installed and these include ujson and uvloop.
One easy solution would be to use requirement.txt files, define exactly what requirements we need and then use pip install --no-deps.

@chenjr0719
Copy link
Member

I have some ideas about how to modify our tox.ini to meet this requirement. But, I will wait until #151 is merged if you don't mind. 😬

@AtomsForPeace
Copy link
Contributor Author

Of course

@stale
Copy link

stale bot commented Apr 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is incorrect, please respond with an update. Thank you for your contributions.

@stale stale bot added the stale label Apr 12, 2020
@stale stale bot closed this as completed May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants