-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project looks dead #68
Comments
Holy crap that's a lot PR. Is there anyway to link people from outside of this project to help out? It seems pretty useful for the life of sanic. |
@channelcat @Typhon66 I'd love to volunteer to assist maintaining this repo, can anything be arranged so that development can continue on sanic-openapi? Many of the bugs we're encountering have been fixed in PRs. Thanks for your time! |
Any volunteer, which ready to maintain a fork? :) |
There's a pseudo fork, with attrs support: |
sanic-attrs looked to be mostly dead as well. I've started my own fork and have slowly been working on it: I've started by adding some code coverage, static analysis, and publishing to PyPI through CircleCI. In the coming weeks, I want to start adding some more functionality and support for more parts of the Swagger spec. So far, I've basically left the code untouched while I setup all the other auxiliary parts of a good OSS project. |
Sanic has turned into a community driven project now (https://sanicframework.org/) and the community has gained control over the releases, PRs and such. There are no clear plans on sanic-openapi yet, but it might become community driven as well. At least control of the project is in the same hands as the sanic project now. So better times ahead I think... |
@DirkGuijt Thanks for posting this. As you said, we are working to build the community, and have this repo and the To be entirely honest, most (if not all) of the attention has been on organizing @abatilo, if you would like to take your fork and bring it back into the main, we would certainly welcome someone to stand up and help champion |
@DirkGuijt sorry for haven't find time to jump in this issue before. Yes, indeed, As @ahopkins stated, we have full attention on Sanic right now because it needs a lot of work, not only in code, but quality, documentation and the list can go on and on. I'm also working hard on a component injection system for Sanic that will allow developers to provide some extra functionality to their endpoints and even extract and provide, if the user wants to, a OpenAPI / Swagger definition of their endpoints using Python type annotations (you can see my comment describing part of the idea in here). Of course I would like to see this on Sanic, but that will likely not happen in the near future nor I'll know if I would be able to provide a fully compatible plugin for Sanic or would have to override a lot of it's core functionalities (like I'm doing right now) to make this sort of thing to work properly. |
@ahopkins That would be awesome. What steps do I need to take to get that started? |
@abatilo check out the Sanic dev group and the Sanic Community Forums 😉 |
@abatilo Welcome to the team. 😁 |
@ahopkins Thank you! Happy to be here. Random question. Does anyone have the sanic-openapi PyPI credentials? Otherwise we might just want to rename this repo and stick with the sanic-swagger PyPI entry that I started? |
We are working on it: pypi/warehouse#4832 I am closing this issue for because @abatilo is going to help us bring it back from the dead. 👍 Feel free to carry on the conversation. I think we should try and keep the |
Agreed! Welcome, @abatilo ! 💪 |
The latest release contains at least one show-stopping bug (#50), and contains other errors. Meanwhile, there are 12 pull requests which have been sitting unmerged (and likely not even reviewed) for months.
It seems that @Typhon66 can no longer maintain this project. Is it possible to add another maintainer to the project and at least merge all the working PRs? I cannot dedicate a significant amount of time to this, but I would be willing to at least merge the PRs.
If @Typhon66 and @channelcat are not active, and cannot add another maintainer, the repository should probably be forked.
The text was updated successfully, but these errors were encountered: