Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix routes with different depth #13

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

nichmor
Copy link
Contributor

@nichmor nichmor commented Mar 25, 2021

Fix _find_route function generation when two route are overlapping and have different depth.
Example:

/foo/<foo_id>/bars_ids
/foo/<foo_id>/bars_ids/<bar_id>/settings/<group_id>/groups

@ahopkins
Copy link
Member

This looks great. Thanks. I confirmed this and looks like you have a nice test case to cover.

@ahopkins
Copy link
Member

Release going out shortly.

You can either upgrade this one package, or force Sanic to reinstall.

@nichmor
Copy link
Contributor Author

nichmor commented Mar 25, 2021

Thank you!

@ahopkins
Copy link
Member

@rudyvan
Copy link

rudyvan commented Mar 25, 2021

Thanks for the quick reply and all the awesome work done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants