Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate string #12

Closed
ahopkins opened this issue Mar 24, 2021 · 0 comments · Fixed by #37
Closed

Deprecate string #12

ahopkins opened this issue Mar 24, 2021 · 0 comments · Fixed by #37

Comments

@ahopkins
Copy link
Member

The string parameter type is somewhat confusing since we also have int. Often people new to Sanic will think it should be str.

I propose that it becomes deprecated, we add it as an alias to str for some period of time, and then remove it prior to the 21.12 Sanic LTS.

@sanic-org/framework thoughts?
@ahopkins ahopkins mentioned this issue May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V2routing sanic-org/sanic-routing
1 participant
@ahopkins