Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to change worker amount online #2616

Closed
1 task done
yangbo1024 opened this issue Dec 7, 2022 · 3 comments · Fixed by #2617
Closed
1 task done

How to change worker amount online #2616

yangbo1024 opened this issue Dec 7, 2022 · 3 comments · Fixed by #2617
Labels
feature request

Comments

@yangbo1024
Copy link

yangbo1024 commented Dec 7, 2022 •
edited

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Condition: must keep server online, then:

  1. Is there a way to change (increase) the amount of running workers?
  2. How can I add a new worker, by multiplexer, or manager?
    The "online" means never lose any request all the time

Describe the solution you'd like

  1. like gunicorn, can modify the "workers" in setting, then send a HUP signal to main process.
  2. like gunicorn, send a TTIN signal to main process.

Additional context

thanks.
@ahopkins
Copy link
Member

ahopkins commented Dec 7, 2022

This feature does not exist yet, but I'm hoping to get it in for v22.12

@ahopkins ahopkins mentioned this issue Dec 7, 2022
Merged
@ahopkins
Copy link
Member

ahopkins commented Dec 7, 2022

@yangbo1024 I just pushed the branch that has this feature.

@yangbo1024
Copy link
Author

That's so great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Scale workers sanic-org/sanic
2 participants
@ahopkins @yangbo1024