Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move list of adjectives into its own file #24

Closed
uwaseem opened this issue Oct 19, 2020 · 3 comments
Closed

Move list of adjectives into its own file #24

uwaseem opened this issue Oct 19, 2020 · 3 comments
Labels
Done Done The issue is done

Comments

@uwaseem
Copy link
Contributor

uwaseem commented Oct 19, 2020

Right now, the list of adjectives sits in index.js.
This is fine for now, but as the list grows, the file itself will become clunky.
To keep things clean and readable, it might be worth moving the list into its own file.

@sanijalal sanijalal added the good first issue Good for newcomers label Oct 19, 2020
@lixiaoqity
Copy link

I'd like to create a new dir to store these data.

@Yasas4D
Copy link

Yasas4D commented Oct 19, 2020

Hi, Please assign me

@Yasas4D
Copy link

Yasas4D commented Oct 19, 2020

Hi, I'm able to successfully apply the changes.. Also, I suggest a new function for getRandomNumber function as your one is not working as expected. Thank you

@sanijalal sanijalal added Done Done The issue is done and removed good first issue Good for newcomers labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Done Done The issue is done
Projects
None yet
Development

No branches or pull requests

4 participants