Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fit param to max on the image loader #1520

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

valse
Copy link
Contributor

@valse valse commented May 22, 2024

The default value for the fit param should be set to max to support the vertical images out of the box.

The default value for the fit param should be set to max to support the vertical images out of the box.

Signed-off-by: Marco Valsecchi <marco.valsecchi@gmail.com>
@valse valse requested a review from a team as a code owner May 22, 2024 04:51
Copy link

vercel bot commented May 22, 2024

@valse is attempting to deploy a commit to the Sanity Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-sanity-static ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 7:24pm

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! If you apply the suggested change I'll approve and release 👍

packages/next-sanity/src/image/imageLoader.ts Outdated Show resolved Hide resolved
Co-authored-by: Cody Olsen <81981+stipsan@users.noreply.github.com>
Signed-off-by: Marco Valsecchi <marco.valsecchi@gmail.com>
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks 💛

@stipsan stipsan merged commit fae2812 into sanity-io:main May 22, 2024
12 checks passed
@ecospark ecospark bot mentioned this pull request May 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants