-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle drafts and published - fix various issues #64
Conversation
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is protestware and troll packages?This package is a joke, parody, or includes undocumented or hidden behavior unrelated to its primary function. Consider that consuming this package my come along with functionality unrelated to its primary purpose. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome housekeeping! LGTM (as long as you remove the dryrun flag todo)
.github/workflows/main.yml
Outdated
with: | ||
cache: npm | ||
node-version: lts/* | ||
- run: npm ci | ||
# Branches that will release new versions are defined in .releaserc.json | ||
- run: npx semantic-release | ||
# @TODO remove --dry-run after verifying everything is good to go | ||
- run: npx semantic-release --dry-run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dryrun needs to removed from here (todo)
This is great @thebiggianthead!
|
@SimeonGriggs Sorted. I've also added a counter on the drag when multiple items are being moved – I found it a little unclear given not all items are visibly moving so felt this might help... |
Nice touch, LGTM! |
* chore: update plugin-kit and other deps * feat: return patches for published and draft docs * feat: fix routing, add selected document; closes #60, closes #59 * chore: remove duped prettier and eslint configs * feat: migrate to use plugin-utils for listener and feedback. formats code. Closes #63, closes #37 * fix: readd v2 branch * fix: only patch published version if it exists * fix: reenable multi-drag. add drag counter icon * chore: remove dry run flag
Initially I created this branch to fix an issue where sort orders of published docs weren't updated if a draft doc existed. I ended up doing a few more fixes as I noticed things that weren't quite right, so this PR also covers a fair few things:
plugin-kit
and other depssanity-plugin-utils
for the listener and for feedback components. This also solves as issue where a documents moving from draft to publish meant the title no longer displayed in the list pane.