Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perpectives support #34

Closed
luizhop opened this issue Dec 12, 2023 · 2 comments
Closed

Perpectives support #34

luizhop opened this issue Dec 12, 2023 · 2 comments
Assignees

Comments

@luizhop
Copy link
Contributor

luizhop commented Dec 12, 2023

Hello there 馃憢

First of all, really appreciate your work with this library! We are just starting to use Sanity on the company I work for, and having a PHP library to start with is definitely helping a lot, as most our projects are PHP based.

I see Perspectives is something relatively new to Sanity and found a working branch on this repository with changes to implement it, so currently I am using this working branch on my project and wondering are there still active plans to merge it into main?

While using it on my project I saw a notice on error.log, undefined index clientConfig on line 70 of sanity-php/lib/Client.php:
https://github.com/sanity-io/sanity-php/blob/7520615550075eab491152dbb3c7fc6e81d75632/lib/Client.php#L70C79-L70C91

So I've created a pull request with what I believe would be the fix for that: #33

Many thanks!

@sjelfull sjelfull self-assigned this Jan 27, 2024
@sjelfull
Copy link
Member

Hey, thanks for the PR and the reminder. I have tagged v1.5.2 that includes perspectives support.

@luizhop
Copy link
Contributor Author

luizhop commented Feb 9, 2024

Many thanks for that @sjelfull 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants