Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: document should never be null #92

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Nov 27, 2023

Related to #90, should restore the behaviour in v2, but without losing the benefit in v3 in that it doesn't update values like slug.current until it's synced to Content Lake.

@stipsan stipsan requested a review from rdunk November 27, 2023 12:11
Copy link
Member

@rdunk rdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdunk rdunk mentioned this pull request Nov 27, 2023
@stipsan stipsan merged commit 1c4cdd3 into main Mar 18, 2024
8 checks passed
@stipsan stipsan deleted the fix-`document`-should-never-be-`null` branch March 18, 2024 17:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants