Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configurable uploads and import from Mux #350

Merged
merged 11 commits into from Apr 8, 2024
Merged

Conversation

hdoro
Copy link
Collaborator

@hdoro hdoro commented Mar 22, 2024

This PR makes it possible to create video assets with configurable max_resolution, mp4_support and encoding_tier, as well as requesting auto-generation of subtitles and captions. Closes #340 #327 #336 #324

It also introduces the ability to import videos from Mux (closes #290 #53 and #342)

Shout-out and thanks to @evankirkiles for his work on parts of the configuration flow 🙏

@hdoro hdoro requested a review from stipsan March 22, 2024 10:17
@hdoro hdoro requested a review from a team as a code owner March 22, 2024 10:17
Copy link

vercel bot commented Mar 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
sanity-plugin-mux-input ❌ Failed (Inspect) Mar 22, 2024 10:18am
sanity-plugin-mux-input-codesandbox ❌ Failed (Inspect) Mar 22, 2024 10:18am

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@commitlint/cli@18.6.1 Transitive: environment, eval, filesystem, shell +44 1.86 MB escapedcat
npm/@commitlint/config-conventional@18.6.2 Transitive: filesystem +10 171 kB escapedcat
npm/@mux/mux-player-react@2.3.3 Transitive: network +5 13.5 MB mux-npmjs
npm/@mux/upchunk@3.3.2 None +1 878 kB mux-npmjs
npm/@sanity/client@6.15.0 Transitive: environment, network +10 2.92 MB sanity-io
npm/@sanity/icons@2.10.3 None 0 1.23 MB sanity-io
npm/@sanity/image-url@1.0.2 None 0 166 kB rexxars
npm/@sanity/incompatible-plugin@1.0.4 None +1 2.68 MB stipsan
npm/@sanity/pkg-utils@4.3.0 filesystem Transitive: environment, eval, network, shell, unsafe +138 252 MB sanity-io
npm/@sanity/plugin-kit@3.1.10 Transitive: environment, eval, filesystem, network, shell, unsafe +243 266 MB sanity-io
npm/@sanity/semantic-release-preset@4.1.7 Transitive: environment, filesystem, shell +19 389 kB sanity-io
npm/@sanity/ui@2.0.7 Transitive: environment +9 7.37 MB sanity-io
npm/@sanity/uuid@3.0.2 None +2 126 kB rexxars
npm/@sanity/vision@3.30.0 Transitive: environment +25 5.36 MB ricokahler
npm/@types/lodash@4.14.202 None 0 862 kB types
npm/@types/node@20.11.20 None 0 4 MB types
npm/@types/react-is@18.2.4 None 0 5.67 kB types
npm/@types/react@18.2.59 None +3 1.68 MB types
npm/@types/styled-components@5.1.34 None +2 1.28 MB types
npm/@typescript-eslint/eslint-plugin@7.1.0 Transitive: environment, filesystem +22 6.36 MB jameshenry
npm/@typescript-eslint/parser@7.1.0 Transitive: environment, filesystem +15 1.69 MB jameshenry
npm/cz-conventional-changelog@3.3.0 environment Transitive: eval, filesystem, shell +38 2.23 MB commitizen-bot
npm/eslint-config-prettier@9.1.0 None 0 20.8 kB lydell
npm/eslint-config-sanity@7.1.0 Transitive: environment, eval, filesystem +30 3.61 MB sanity-io
npm/eslint-plugin-import@2.29.1 filesystem, unsafe Transitive: eval +29 3.86 MB ljharb
npm/eslint-plugin-prettier@5.1.3 None 0 33.9 kB jounqin
npm/eslint-plugin-simple-import-sort@12.0.0 None 0 37.8 kB lydell
npm/eslint@8.57.0 environment, filesystem Transitive: eval, shell, unsafe +47 9.09 MB eslintbot

🚮 Removed packages: npm/@mux/mux-player-react@1.15.0, npm/@sanity/client@6.8.0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/esbuild@0.19.12
  • orphan: npm/esbuild@0.19.12
Install scripts npm/esbuild@0.20.1

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.19.12
  • @SocketSecurity ignore npm/esbuild@0.20.1

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you! 💖

@stipsan stipsan merged commit 0492fab into main Apr 8, 2024
5 of 11 checks passed
@stipsan stipsan deleted the feat/jan-24-features branch April 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way to choose between Baseline assets and Smart assets pricing Pull / Sync existing Mux Videos
3 participants