Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for react@18? #3456

Closed
ale917k opened this issue Jul 30, 2022 · 7 comments
Closed

Support for react@18? #3456

ale917k opened this issue Jul 30, 2022 · 7 comments

Comments

@ale917k
Copy link

ale917k commented Jul 30, 2022

I understand react v18 was "only" released over 4 months ago, but it would be nice if support was rolled out given there are not many breaking changes introduced.

In my case I'd like to maintain the latest Next.js features while taking advantage of Yarn workspaces, so I'll have to enforce v18 also for the Sanity Studio (which as a FYI doesn't seem to break any functionality).

The only thing that would bother me at this point would be the constant warning log:

[WARN] The following package versions have not yet been marked as supported:

  react (installed: 18.2.0, want: ^16.9 || ^17)
  react-dom (installed: 18.2.0, want: ^16.9 || ^17)

You _may_ encounter bugs while using these versions.

  To downgrade, run either:

  yarn add "react@17.0.0" "react-dom@17.0.0"

  or

  npm install "react@17.0.0" "react-dom@17.0.0"

Alternatively, if support to new versions need to take much longer, can we consider placing the log upon installation rather than at each sanity start?

@rexxars
Copy link
Member

rexxars commented Aug 8, 2022

Hi Alessio!

We are working on full support for React 18, but we are not quite there yet :)

Stay tuned!

@wdtamagi
Copy link

wdtamagi commented Oct 4, 2022

Any update on that?

@scerelli
Copy link

Any news on this?

@mariuslundgard
Copy link
Member

mariuslundgard commented Oct 26, 2022

Sanity Studio v3 will support React 18. It's currently released as sanity@3.0.0-dev-preview.22. More info here.

@scerelli
Copy link

@mariuslundgard ye i know this, but upgrading to V3 means we got to deal with breaking changes, do you already have a migration guide or even a draft of it?

@mariuslundgard
Copy link
Member

@scerelli The migration docs are here: https://beta.sanity.io/docs/platform/studio/v2-to-v3.

Please reach out in the GitHub discussions or in our community Slack if you have questions or suggestions along the way.

@rexxars
Copy link
Member

rexxars commented Dec 12, 2022

Sanity Studio v3 is now released with full React 18 support.

@rexxars rexxars closed this as completed Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants