Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Dataset import should not fail on failed asset download #54

Closed
thomax opened this issue Apr 5, 2017 · 2 comments
Closed

[cli] Dataset import should not fail on failed asset download #54

thomax opened this issue Apr 5, 2017 · 2 comments
Assignees

Comments

@thomax
Copy link
Contributor

thomax commented Apr 5, 2017

Say your image assets are sourced from Amazon S3. Currently, if the importer gets a failed download (say 403) the whole import will die immediately. This might be the desired default (not sure about that), but we should have a "keep going on missing asset"-flag which just saves the current document without the desired asset. Finally, when the import is done, produce a report which lists:

  • document(s) which encountered a problem
  • which asset URLs failed
  • response status code (403 or whatever)

Same behaviour should occur if assets are local files.

Maybe name the flag keep-going-on-missing-asset, dont-stop-on-missing-asset or tolerate-missing-assets?

@thomax
Copy link
Contributor Author

thomax commented Oct 3, 2018

This would be ultra-useful in the coming weeks.

@rexxars
Copy link
Member

rexxars commented Oct 3, 2018

Are we expected to be able to recover from this situation (say, retry the failed assets), or just leave them as documents without the referenced image?

If yes, we'll have to:

  • Generate a map of the failed downloads, with document IDs and field paths
  • Write that map to disk somewhere
  • Provide a command line tool/flag for retrying the downloads

@oyvindrostad oyvindrostad added this to the Sprint week 41 (not started) milestone Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants