Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity's dependency on @sentry/react should not exist - devDependency instead #7004

Closed
AryanJ-NYC opened this issue Jun 20, 2024 · 1 comment

Comments

@AryanJ-NYC
Copy link

AryanJ-NYC commented Jun 20, 2024

Describe the bug
Sentry is a bug reporting tool used by some projects. Most projects probably don't use Sentry. This shouldn't be a dependency and probably should be a devDependency.

Which versions of Sanity are you using?
@sanity/cli (global) 3.47.1 (up to date)

What operating system are you using?
MacOS

Which versions of Node.js / npm are you running?
9.6.7
v18.17.0

Context
https://github.com/sanity-io/sanity/blob/next/packages/sanity/package.json

Copy link
Member

runeb commented Jun 20, 2024

Sentry is used in certain circumstances to report errors in core Sanity code to Sanity. You are right that most project will not see this module being used at runtime and there is no requirements that users of Sanity set up Sentry or any other error reporting.

@runeb runeb closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants