New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(menu): update menu and menu items styles #1166
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
src/primitives/_selectable/style.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what's the rationale for applying hover styles to both active
and selected
states here? These changes mean that it's not possible to disambiguate between the 'selected' menu item and the one that's being currently hovered.
To better illustrate, try visit this example and click any menu item and then press the up or down arrows – you'll be able to see the item that is 'selected' whilst having a hover state on the previously clicked button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @robinpyon In the figma file the selected and hover states are the same that's the reason they are repeated.
With the redesign, the tint used for the selected state background is 50
so we don't have a way to set a lighter color in hover like in the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying @pedrobonamin! Possibly something we can iterate on in future, I do think there's value in differentiating between those states.
2b6be12
to
facf171
Compare
0e8d0c7
to
b3e90ad
Compare
b3e90ad
to
abb7c09
Compare
* feat(menu): add menu stories and update menu shadows * feat(menu-item): add menu item stories, update selectable styles
* feat(menu): add menu stories and update menu shadows * feat(menu-item): add menu item stories, update selectable styles
* feat(menu): add menu stories and update menu shadows * feat(menu-item): add menu item stories, update selectable styles
* feat(menu): add menu stories and update menu shadows * feat(menu-item): add menu item stories, update selectable styles
Updates menu and menu item styles to match facelift.
Refactors menu item to support new props:
subText
badgeText
https://sanity-ui-storybook-git-edx-484-menu.sanity.build/?path=/story/components-menu--menu-items-variants&globals=theme:light
Examples:
Light mode
Dark mode