fix(facelift): add unstableDisableFocusRing prop to text inputs #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pedrobonamin
force-pushed
the
EDX-757/unstableDisableFocus
branch
from
52c18d3
to
fce52ac
Compare
robinpyon
approved these changes
Nov 14, 2023
mariuslundgard
pushed a commit
that referenced
this pull request
Dec 7, 2023
This was referenced Jan 15, 2024
robinpyon
pushed a commit
that referenced
this pull request
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new
unstableDisableFocusRingprop to text inputs.When true, text inputs won't show the focus ring, this is necessary for the ui updates shown in the video:
https://www.loom.com/share/7f67d96d5fe04e32a3a2f927bd8a7f32