fix: remove crossfade pollution on fade in transitions #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stipsan
force-pushed
the
fix-crossfade-pollution
branch
from
74493fb
to
fb898c1
Compare
stipsan
force-pushed
the
fix-crossfade-pollution
branch
from
fb898c1
to
e07d0d0
Compare
stipsan
force-pushed
the
fix-crossfade-pollution
branch
from
e07d0d0
to
09c57f5
Compare
This was referenced Jan 15, 2024
robinpyon
pushed a commit
that referenced
this pull request
Jan 16, 2024
fix: remove crossfade pollution from transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crossfade pollution happens when rich content and text crossfades in a transition, below is a slowed down frame-by-frame demonstrating it:
frame.by.frame.mov
The fix is to fade in the backdrop first, then the content, the video below demonstrates the before and after with a slowed down transition so it's easier to see:
toast.pollution.slomo.mov
The fix is applied to Toasts, Tooltips and Popovers.