Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/add-intro-template #23

Merged
merged 4 commits into from Oct 19, 2022
Merged

feat/add-intro-template #23

merged 4 commits into from Oct 19, 2022

Conversation

ninaandal
Copy link
Contributor

@ninaandal ninaandal commented Oct 17, 2022 •
edited

Link to figma: https://www.figma.com/file/C77wPdW97bGo7Of1vMAc80/V3-Starters-%E2%80%93-Prototypes?node-id=64%3A1094

Test that all the links that they go to the correct places

@vercel
Copy link

vercel bot commented Oct 17, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
vercel-next-js-examples-cms-sanity-studio-v3 ✅ Ready (Inspect) Visit Preview ✅ 1 resolved Oct 18, 2022 at 11:32AM (UTC)

@kmelve
Copy link
Member

kmelve commented Oct 17, 2022 •
edited

📝 Changed routes:

/
Screenshot of /
(view full size)

Commit 12a4ac7 (https://vercel-next-js-examples-cms-sanity-studio-v3-agoulh2iq.sanity.build).

@ninaandal
Copy link
Contributor Author

📝 Changed routes:

/
Screenshot of /
(view full size)
Commit 7f204df (https://vercel-next-js-examples-cms-sanity-studio-v3-lerd186v8.sanity.build).

I don't understand?

RitaDias
RitaDias reviewed Oct 18, 2022
View reviewed changes
Copy link
Contributor

@RitaDias RitaDias left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions ✨ (also trying the vercel feedback for the first time!)

components/intro-template.tsx Show resolved Hide resolved
components/intro-template.tsx Show resolved Hide resolved
@stipsan
Copy link
Member

stipsan commented Oct 18, 2022

I don't understand?

It's not actually @kmelve it's just the Vercel bot that tells us anytime a PR changes result in visual changes in your nextjs app :)

stipsan
stipsan reviewed Oct 18, 2022
View reviewed changes
components/intro-template.tsx
Comment on lines +38 to +39
href="https://cms-sanity-2-eight.vercel.app/studio"
text="https://cms-sanity-2-eight.vercel.app/studio"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these links are wrong?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what they should be? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't but let's fix it in a follow up PR 😄

stipsan
stipsan approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb, let's get this merged and iterate in follow up PRs instead of letting this PR hang 😄

components/intro-template.tsx
Comment on lines +38 to +39
href="https://cms-sanity-2-eight.vercel.app/studio"
text="https://cms-sanity-2-eight.vercel.app/studio"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't but let's fix it in a follow up PR 😄

@stipsan stipsan merged commit 5699ade into main Oct 19, 2022
@stipsan stipsan deleted the feat/new-intro-design branch October 19, 2022 15:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RitaDias RitaDias RitaDias left review comments

@stipsan stipsan stipsan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ninaandal @kmelve @stipsan @RitaDias