Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support localization(i18n) in the App #77

Closed
sanjeevyadavIT opened this issue Nov 1, 2019 · 0 comments · Fixed by #78
Closed

Support localization(i18n) in the App #77

sanjeevyadavIT opened this issue Nov 1, 2019 · 0 comments · Fixed by #78
Assignees
@sanjeevyadavIT
Labels
Priority: Low Status: Completed Task completed Type: Enhancement New feature or request
Projects
MageCart Roadmap

Comments

@sanjeevyadavIT
Copy link
Owner

sanjeevyadavIT commented Nov 1, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
Currently strings are either hard-coded or reference from strings.js , which is not good for support of localization.

Describe the solution you'd like

  1. use i18n-js & react-native-localize package in App
  2. Follow similar project structure as in ignite-bowser boilerplate
  3. Remove all hard coded strings
  4. Reference all strings from i18n folder

Additional context
Look for best way to support i18n in react/react-native
@sanjeevyadavIT sanjeevyadavIT added Type: Enhancement New feature or request Priority: Low Status: On Hold No current development going on labels Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT self-assigned this Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT changed the title Support i18n in the App Support localization(i18n) in the App Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT added Status: In Progress Working on the issue and removed Status: On Hold No current development going on labels Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT added this to In progress in MageCart Roadmap Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT mentioned this issue Nov 1, 2019
Merged
4 tasks
@sanjeevyadavIT sanjeevyadavIT added Status: Completed Task completed and removed Status: In Progress Working on the issue labels Nov 1, 2019
@sanjeevyadavIT sanjeevyadavIT moved this from In progress to Done in MageCart Roadmap Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjeevyadavIT sanjeevyadavIT

Labels
Priority: Low Status: Completed Task completed Type: Enhancement New feature or request
Projects
MageCart Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for localization sanjeevyadavIT/magento_react_native
1 participant
@sanjeevyadavIT