forked from kubermatic/kubermatic
/
sync_resource.go
454 lines (411 loc) · 17.6 KB
/
sync_resource.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
/*
Copyright 2020 The Kubermatic Kubernetes Platform contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package rbac
import (
"fmt"
kubermaticv1 "github.com/kubermatic/kubermatic/api/pkg/crd/kubermatic/v1"
rbacv1 "k8s.io/api/rbac/v1"
"k8s.io/apimachinery/pkg/api/equality"
kerrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/client-go/kubernetes"
rbaclister "k8s.io/client-go/listers/rbac/v1"
"k8s.io/klog"
)
// syncProjectResource generates RBAC Role and Binding for a resource that belongs to a project.
// in order to support multiple cluster this code doesn't retrieve the project from the kube-api server
// instead it assumes that all required information is stored in OwnerReferences or in Labels (for cluster resources)
//
// note:
// the project resources live only on master cluster and cluster resources are on master and seed clusters
// we cannot use OwnerReferences for cluster resources because they are on clusters that don't have corresponding
// project resource and will be automatically gc'ed
func (c *resourcesController) syncProjectResource(item *resourceToProcess) error {
projectName := ""
for _, owner := range item.metaObject.GetOwnerReferences() {
if owner.APIVersion == kubermaticv1.SchemeGroupVersion.String() && owner.Kind == kubermaticv1.ProjectKindName &&
len(owner.Name) > 0 && len(owner.UID) > 0 {
projectName = owner.Name
break
}
}
if len(projectName) == 0 {
projectName = item.metaObject.GetLabels()[kubermaticv1.ProjectIDLabelKey]
}
if len(projectName) == 0 {
return fmt.Errorf("unable to find owing project for the object name = %s, gvr = %s", item.metaObject.GetName(), item.gvr.String())
}
if len(item.metaObject.GetNamespace()) == 0 {
if err := ensureClusterRBACRoleForNamedResource(projectName, item.gvr.Resource, item.kind, item.metaObject, item.clusterProvider.kubeClient, item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(metav1.NamespaceAll).Rbac().V1().ClusterRoles().Lister()); err != nil {
return fmt.Errorf("failed to sync RBAC ClusterRole for %s resource for %s cluster provider, due to = %v", item.gvr.String(), item.clusterProvider.providerName, err)
}
if err := ensureClusterRBACRoleBindingForNamedResource(projectName, item.gvr.Resource, item.kind, item.metaObject, item.clusterProvider.kubeClient, item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(metav1.NamespaceAll).Rbac().V1().ClusterRoleBindings().Lister()); err != nil {
return fmt.Errorf("failed to sync RBAC ClusterRoleBinding for %s resource for %s cluster provider, due to = %v", item.gvr.String(), item.clusterProvider.providerName, err)
}
if item.kind == kubermaticv1.ClusterKindName {
if err := c.ensureRBACRoleForClusterAddons(projectName, item.metaObject, item.clusterProvider.kubeClient, item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(metav1.NamespaceAll).Rbac().V1().Roles().Lister()); err != nil {
return fmt.Errorf("failed to sync RBAC Role for %s resource for %s cluster provider in namespace %s, due to = %v", item.gvr.String(), item.clusterProvider.providerName, item.metaObject.GetNamespace(), err)
}
if err := c.ensureRBACRoleBindingForClusterAddons(projectName, item.metaObject, item.clusterProvider.kubeClient, item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(metav1.NamespaceAll).Rbac().V1().RoleBindings().Lister()); err != nil {
return fmt.Errorf("failed to sync RBAC RoleBinding for %s resource for %s cluster provider in namespace %s, due to = %v", item.gvr.String(), item.clusterProvider.providerName, item.metaObject.GetNamespace(), err)
}
}
return nil
}
err := c.ensureRBACRoleForNamedResource(projectName,
item.gvr,
item.kind,
item.metaObject.GetNamespace(),
item.metaObject,
item.clusterProvider.kubeClient,
item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(item.metaObject.GetNamespace()).Rbac().V1().Roles().Lister().Roles(item.metaObject.GetNamespace()))
if err != nil {
return fmt.Errorf("failed to sync RBAC Role for %s resource for %s cluster provider in namespace %s, due to = %v", item.gvr.String(), item.clusterProvider.providerName, item.metaObject.GetNamespace(), err)
}
err = c.ensureRBACRoleBindingForNamedResource(projectName,
item.gvr,
item.kind,
item.metaObject.GetNamespace(),
item.metaObject,
item.clusterProvider.kubeClient,
item.clusterProvider.kubeInformerProvider.KubeInformerFactoryFor(item.metaObject.GetNamespace()).Rbac().V1().RoleBindings().Lister().RoleBindings(item.metaObject.GetNamespace()))
if err != nil {
return fmt.Errorf("failed to sync RBAC RoleBinding for %s resource for %s cluster provider in namespace %s, due to = %v", item.gvr.String(), item.clusterProvider.providerName, item.metaObject.GetNamespace(), err)
}
return nil
}
func ensureClusterRBACRoleForNamedResource(projectName string, objectResource string, objectKind string, object metav1.Object, kubeClient kubernetes.Interface, rbacClusterRoleLister rbaclister.ClusterRoleLister) error {
for _, groupPrefix := range AllGroupsPrefixes {
skip, generatedRole, err := shouldSkipClusterRBACRoleBindingForNamedResource(projectName, objectResource, objectKind, groupPrefix, object)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping ClusterRole generation for named resource for group \"%s\" and resource \"%s\"", groupPrefix, objectResource)
continue
}
sharedExistingRole, err := rbacClusterRoleLister.Get(generatedRole.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
// make sure that existing rbac role has appropriate rules/policies
if sharedExistingRole != nil {
if equality.Semantic.DeepEqual(sharedExistingRole.Rules, generatedRole.Rules) {
continue
}
existingRole := sharedExistingRole.DeepCopy()
existingRole.Rules = generatedRole.Rules
if _, err = kubeClient.RbacV1().ClusterRoles().Update(existingRole); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().ClusterRoles().Create(generatedRole); err != nil {
return err
}
}
return nil
}
func ensureClusterRBACRoleBindingForNamedResource(projectName string, objectResource string, objectKind string, object metav1.Object, kubeClient kubernetes.Interface, rbacClusterRoleBindingLister rbaclister.ClusterRoleBindingLister) error {
for _, groupPrefix := range AllGroupsPrefixes {
skip, _, err := shouldSkipClusterRBACRoleBindingForNamedResource(projectName, objectResource, objectKind, groupPrefix, object)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping operation on ClusterRoleBinding because corresponding ClusterRole was not(will not be) created for group %q and %q resource for project %q", groupPrefix, objectResource, projectName)
continue
}
generatedRoleBinding := generateClusterRBACRoleBindingNamedResource(
objectKind,
object.GetName(),
GenerateActualGroupNameFor(projectName, groupPrefix),
metav1.OwnerReference{
APIVersion: kubermaticv1.SchemeGroupVersion.String(),
Kind: objectKind,
UID: object.GetUID(),
Name: object.GetName(),
},
)
sharedExistingRoleBinding, err := rbacClusterRoleBindingLister.Get(generatedRoleBinding.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
if sharedExistingRoleBinding != nil {
if equality.Semantic.DeepEqual(sharedExistingRoleBinding.Subjects, generatedRoleBinding.Subjects) {
continue
}
existingRoleBinding := sharedExistingRoleBinding.DeepCopy()
existingRoleBinding.Subjects = generatedRoleBinding.Subjects
if _, err = kubeClient.RbacV1().ClusterRoleBindings().Update(existingRoleBinding); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().ClusterRoleBindings().Create(generatedRoleBinding); err != nil {
return err
}
}
return nil
}
// shouldSkipClusterRBACRoleBindingForNamedResource will tell you if you should skip the generation of ClusterResource or not,
// because for some kinds we actually don't create ClusterRole
//
// note that this method returns generated role if is not meant to be skipped
func shouldSkipClusterRBACRoleBindingForNamedResource(projectName string, objectResource string, objectKind string, groupPrefix string, object metav1.Object) (bool, *rbacv1.ClusterRole, error) {
generatedRole, err := generateClusterRBACRoleNamedResource(
objectKind,
GenerateActualGroupNameFor(projectName, groupPrefix),
objectResource,
kubermaticv1.SchemeGroupVersion.Group,
object.GetName(),
metav1.OwnerReference{
APIVersion: kubermaticv1.SchemeGroupVersion.String(),
Kind: objectKind,
UID: object.GetUID(),
Name: object.GetName(),
},
)
if err != nil {
return false, generatedRole, err
}
if generatedRole == nil {
return true, nil, nil
}
return false, generatedRole, nil
}
func (c *resourcesController) ensureRBACRoleForNamedResource(projectName string, objectGVR schema.GroupVersionResource, objectKind string, namespace string, object metav1.Object, kubeClient kubernetes.Interface, rbacRoleLister rbaclister.RoleNamespaceLister) error {
for _, groupPrefix := range AllGroupsPrefixes {
skip, generatedRole, err := shouldSkipRBACRoleBindingForNamedResource(projectName, objectGVR, objectKind, groupPrefix, namespace, object)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping Role generation for named resource for group %q and resource %q in namespace %q", groupPrefix, objectGVR.Resource, namespace)
continue
}
sharedExistingRole, err := rbacRoleLister.Get(generatedRole.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
// make sure that existing rbac role has appropriate rules/policies
if sharedExistingRole != nil {
if equality.Semantic.DeepEqual(sharedExistingRole.Rules, generatedRole.Rules) {
continue
}
existingRole := sharedExistingRole.DeepCopy()
existingRole.Rules = generatedRole.Rules
if _, err = kubeClient.RbacV1().Roles(namespace).Update(existingRole); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().Roles(namespace).Create(generatedRole); err != nil {
return err
}
}
return nil
}
func (c *resourcesController) ensureRBACRoleBindingForNamedResource(projectName string, objectGVR schema.GroupVersionResource, objectKind string, namespace string, object metav1.Object, kubeClient kubernetes.Interface, rbacRoleBindingLister rbaclister.RoleBindingNamespaceLister) error {
for _, groupPrefix := range AllGroupsPrefixes {
skip, _, err := shouldSkipRBACRoleBindingForNamedResource(projectName, objectGVR, objectKind, groupPrefix, namespace, object)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping operation on RoleBinding because corresponding Role was not(will not be) created for group %q and %q resource for project %q in namespace %q", groupPrefix, objectGVR.Resource, projectName, namespace)
continue
}
generatedRoleBinding := generateRBACRoleBindingNamedResource(
objectKind,
object.GetName(),
GenerateActualGroupNameFor(projectName, groupPrefix),
namespace,
metav1.OwnerReference{
APIVersion: objectGVR.GroupVersion().String(),
Kind: objectKind,
UID: object.GetUID(),
Name: object.GetName(),
},
)
sharedExistingRoleBinding, err := rbacRoleBindingLister.Get(generatedRoleBinding.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
if sharedExistingRoleBinding != nil {
if equality.Semantic.DeepEqual(sharedExistingRoleBinding.Subjects, generatedRoleBinding.Subjects) {
continue
}
existingRoleBinding := sharedExistingRoleBinding.DeepCopy()
existingRoleBinding.Subjects = generatedRoleBinding.Subjects
if _, err = kubeClient.RbacV1().RoleBindings(namespace).Update(existingRoleBinding); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().RoleBindings(namespace).Create(generatedRoleBinding); err != nil {
return err
}
}
return nil
}
// shouldSkipRBACRoleBindingForNamedResource will tell you if you should skip the generation of ClusterResource or not,
// because for some kinds we actually don't create Role
//
// note that this method returns generated role if is not meant to be skipped
func shouldSkipRBACRoleBindingForNamedResource(projectName string, objectGVR schema.GroupVersionResource, objectKind string, groupPrefix string, namespace string, object metav1.Object) (bool, *rbacv1.Role, error) {
generatedRole, err := generateRBACRoleNamedResource(
objectKind,
GenerateActualGroupNameFor(projectName, groupPrefix),
objectGVR.Resource,
objectGVR.Group,
object.GetName(),
namespace,
metav1.OwnerReference{
APIVersion: objectGVR.GroupVersion().String(),
Kind: objectKind,
UID: object.GetUID(),
Name: object.GetName(),
},
)
if err != nil {
return false, generatedRole, err
}
if generatedRole == nil {
return true, nil, nil
}
return false, generatedRole, nil
}
func (c *resourcesController) ensureRBACRoleForClusterAddons(projectName string, object metav1.Object, kubeClient kubernetes.Interface, roleLister rbaclister.RoleLister) error {
cluster, ok := object.(*kubermaticv1.Cluster)
if !ok {
return fmt.Errorf("ensureRBACRoleForClusterAddons called with non-cluster: %+v", object)
}
roleNamespacedLister := roleLister.Roles(cluster.Status.NamespaceName)
for _, groupPrefix := range AllGroupsPrefixes {
skip, generatedRole, err := shouldSkipRBACRoleForClusterNamespaceResource(
projectName,
cluster,
kubermaticv1.AddonResourceName,
kubermaticv1.GroupName,
kubermaticv1.AddonKindName,
groupPrefix)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping Role generation for cluster addons for group %q and cluster namespace %q", groupPrefix, cluster.Status.NamespaceName)
continue
}
sharedExistingRole, err := roleNamespacedLister.Get(generatedRole.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
// make sure that existing rbac role has appropriate rules/policies
if err == nil { // sharedExistingRole found
if equality.Semantic.DeepEqual(sharedExistingRole.Rules, generatedRole.Rules) {
continue
}
existingRole := sharedExistingRole.DeepCopy()
existingRole.Rules = generatedRole.Rules
if _, err = kubeClient.RbacV1().Roles(cluster.Status.NamespaceName).Update(existingRole); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().Roles(cluster.Status.NamespaceName).Create(generatedRole); err != nil {
return err
}
}
return nil
}
func (c *resourcesController) ensureRBACRoleBindingForClusterAddons(projectName string, object metav1.Object, kubeClient kubernetes.Interface, roleBindingLister rbaclister.RoleBindingLister) error {
cluster, ok := object.(*kubermaticv1.Cluster)
if !ok {
return fmt.Errorf("ensureRBACRoleBindingForClusterAddons called with non-cluster: %+v", object)
}
roleBindingNamespacedLister := roleBindingLister.RoleBindings(cluster.Status.NamespaceName)
for _, groupPrefix := range AllGroupsPrefixes {
skip, _, err := shouldSkipRBACRoleForClusterNamespaceResource(
projectName,
cluster,
kubermaticv1.AddonResourceName,
kubermaticv1.GroupName,
kubermaticv1.AddonKindName,
groupPrefix)
if err != nil {
return err
}
if skip {
klog.V(4).Infof("skipping RoleBinding generation for cluster addons for group %q and cluster namespace %q", groupPrefix, cluster.Status.NamespaceName)
continue
}
generatedRoleBinding := generateRBACRoleBindingForClusterNamespaceResource(
cluster,
GenerateActualGroupNameFor(projectName, groupPrefix),
kubermaticv1.AddonKindName,
)
sharedExistingRoleBinding, err := roleBindingNamespacedLister.Get(generatedRoleBinding.Name)
if err != nil {
if !kerrors.IsNotFound(err) {
return err
}
}
if err == nil { // sharedExistingRoleBinding found
if equality.Semantic.DeepEqual(sharedExistingRoleBinding.Subjects, generatedRoleBinding.Subjects) {
continue
}
existingRoleBinding := sharedExistingRoleBinding.DeepCopy()
existingRoleBinding.Subjects = generatedRoleBinding.Subjects
if _, err = kubeClient.RbacV1().RoleBindings(cluster.Status.NamespaceName).Update(existingRoleBinding); err != nil {
return err
}
continue
}
if _, err = kubeClient.RbacV1().RoleBindings(cluster.Status.NamespaceName).Create(generatedRoleBinding); err != nil {
return err
}
}
return nil
}
// shouldSkipRBACRoleForClusterNamespaceResource will tell you if you should skip the generation of Role/Rolebinding or not,
// because for some groupPrefixes we actually don't create Role
//
// note that this method returns generated role if is not meant to be skipped
func shouldSkipRBACRoleForClusterNamespaceResource(projectName string, cluster *kubermaticv1.Cluster, policyResource, policyAPIGroups, kind, groupPrefix string) (bool, *rbacv1.Role, error) {
generatedRole, err := generateRBACRoleForClusterNamespaceResource(
cluster,
GenerateActualGroupNameFor(projectName, groupPrefix),
policyResource,
policyAPIGroups,
kind,
)
if err != nil {
return false, generatedRole, err
}
if generatedRole == nil {
return true, nil, nil
}
return false, generatedRole, nil
}