New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Retries Before Giving Up #2

Open

sanketplus opened this issue Jun 23, 2020 · 1 comment

Labels

Owner

sanketplus commented Jun 23, 2020

Currently, a goroutine periodically pings on the connection that holds the lock. If a ping fails, it bails out and closes the connection.

Confirm what happens to connection when a ping fails
If connection is still kept in pool, consider multiple ping retries before giving up (and possibly make it configurable)

sanketplus added the enhancement label

Owner Author

sanketplus commented Jun 28, 2020

After reading driver's code and golang sql wrapper

driver returns badConn error if ping fails
if ping was done on a connection, connection is closed https://golang.org/src/database/sql/sql.go?s=50229:50282#L1914

so most likely, retries do not make sense. Confirm this by doing a simulated run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment