New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix remove deprecated findDOMNode method #255
Bugfix remove deprecated findDOMNode method #255
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried to use the build after these changes?
@LEMing yes, of course. There is no problem with build. I already checked. |
Would love to have this one merged too 🙂 |
would be awesome to have that merged 🥰 |
I fully support this MR |
can you please consider to merge this |
Please put this on live |
Please, accept this PR. |
Please merge, @sanniassin :) |
@sanniassin, could you pretty please merge this? |
Please merge this pull request, @sanniassin. |
Please merge this pull request, @sanniassin. |
How many people does it take to approve to merge this? |
Any news? |
@sanniassin Any news? Can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏🏾
@sanniassin Can you merge this? We needing a lot. |
@sanniassin Can you please merge? |
This Pull Request has been open for a while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanniassin Could you please merge this PR?
I'm closing this pr, since author of project does not respond for PR a long time. As @pbarbiero I've forked this project to solve this problem. You can install it. |
For those who are using version 2.0.4, here is a fork with the fix zenbill#1. The bundled files are in the repo too, so just point your package.json to our |
There's actually a fundamental reason why this PR can't be merged. It breaks the tests for passing in children: function Input(props) {
return (
<InputMask mask="99/99/9999" value={props.value} onChange={props.onChange}>
<MaterialInput type="tel" disableUnderline />
</InputMask>
);
} You need the |
Currently, we get such a warning:
Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputElement which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node
This problem happens because findDOMNode method deprecated. So we don't need to use it.
This PR should solve this problem.