Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix remove deprecated findDOMNode method #255

Closed
wants to merge 1 commit into from
Closed

Bugfix remove deprecated findDOMNode method #255

wants to merge 1 commit into from

Conversation

Temirtator
Copy link

Currently, we get such a warning:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of InputElement which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

This problem happens because findDOMNode method deprecated. So we don't need to use it.

This PR should solve this problem.

image

Copy link

@LEMing LEMing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried to use the build after these changes?

@Temirtator
Copy link
Author

Temirtator commented Apr 8, 2021

@LEMing yes, of course. There is no problem with build. I already checked.

@eltaiguer
Copy link

Would love to have this one merged too 🙂

@salgado-baggy
Copy link

would be awesome to have that merged 🥰

@blaze-su
Copy link

I fully support this MR

@luisbarrientosf
Copy link

can you please consider to merge this

@yepMad
Copy link

yepMad commented Jul 1, 2021

Please put this on live

@IncognitaDev
Copy link

Please, accept this PR.

@rafaelcavalcante
Copy link

rafaelcavalcante commented Aug 19, 2021

Please merge, @sanniassin :)

@hicaro
Copy link

hicaro commented Sep 3, 2021

@sanniassin, could you pretty please merge this?

@Idaslon
Copy link

Idaslon commented Oct 22, 2021

Please merge this pull request, @sanniassin.

@gilvaju
Copy link

gilvaju commented Oct 31, 2021

Please merge this pull request, @sanniassin.

@yepMad
Copy link

yepMad commented Nov 17, 2021

How many people does it take to approve to merge this?

@ksenofobius
Copy link

Any news?

@TomBeckett
Copy link

@sanniassin Any news? Can we merge?

Copy link

@oDevBR oDevBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏾

@lucalves
Copy link

@sanniassin Can you merge this? We needing a lot.

@greguintow
Copy link

@sanniassin Can you please merge?

@mateussouza-ms
Copy link

This Pull Request has been open for a while.
@sanniassin Will it be merged?

Copy link

@RamonEspinosa RamonEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanniassin Could you please merge this PR?

@Temirtator
Copy link
Author

Temirtator commented Mar 22, 2022

I'm closing this pr, since author of project does not respond for PR a long time.

As @pbarbiero I've forked this project to solve this problem. You can install it.

https://github.com/Temirtator/react-input-mask-format

@Temirtator Temirtator closed this Mar 22, 2022
@belgamo
Copy link

belgamo commented Mar 22, 2022

For those who are using version 2.0.4, here is a fork with the fix zenbill#1. The bundled files are in the repo too, so just point your package.json to our main branch and you should be ready to go.

@ianchanning
Copy link

ianchanning commented Feb 18, 2023

There's actually a fundamental reason why this PR can't be merged. It breaks the tests for passing in children:

function Input(props) {
  return (
    <InputMask mask="99/99/9999" value={props.value} onChange={props.onChange}>
      <MaterialInput type="tel" disableUnderline />
    </InputMask>
  );
}

You need the findDOMNode to find the <input> DOM element within the <MaterialInput> (or in my case a custom <Input> functional component).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet