Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add platform tags #38

Closed
x87 opened this issue Apr 30, 2021 · 9 comments
Closed

add platform tags #38

x87 opened this issue Apr 30, 2021 · 9 comments
Milestone

Comments

@x87
Copy link
Contributor

x87 commented Apr 30, 2021

  • platform_any
  • platform_pc
  • platform_mobile
  • platform_console

could be multi-choice

@x87 x87 added this to the v3 milestone Apr 30, 2021
@x87
Copy link
Contributor Author

x87 commented May 4, 2021

also need a filter by platforms.

initially tag all commands with platform_any

@x87
Copy link
Contributor Author

x87 commented May 5, 2021

@XMDS what are your thoughts on the list of platforms for each game? Do you think that the generic names I added above ☝️ would cover all use cases or we might need more specific ones, like: platform_xbox360, etc? please share

@XMDS
Copy link
Member

XMDS commented May 7, 2021

Yes it is. I think that's it. We do not need to classify the host platform specifically. Because most of their commands are universal, only a few commands are independent of a certain platform. Moreover, the mainstream of the GTA 3D series of games is still on PC and Mobile, and the console version of the game lacks modified MOD plug-ins. We do not need to be specific to a certain platform. It is like the mobile platform is divided into Android and ios, but there is no difference in essence.

@x87
Copy link
Contributor Author

x87 commented May 8, 2021

the mobile platform is divided into Android and ios, but there is no difference in essence.

but speaking of CLEO opcodes, for example, there is a difference, since some commands only exist for Android version of the game.

Also some commands only exist in a particular game version/release. For example,
0482 SET_THREAT_REACTION_RANGE_MULTIPLIER // only work with GTA 3 v1.0, does not work with GTA3 1.1
059C in Vice City have different parameters for US and JP versions.
059A is not a return_false command, but presumably it returns true on the Australian release of the game.

In this sense, for accurate descriptions and covering all possible game releases we have to think about extra dimension for commands grouping in addition to extension and id. Game version?

@x87
Copy link
Contributor Author

x87 commented May 8, 2021

Game
 |-- Platform (platform_any, platform_pc, platform_console, platform_mobile, platform_android, platform_ios)
   |-- Version (version_any, version_10, version_11, version_20, version_30)
     |-- Extension (default, cleo, ...)
       |-- Command Id (0000, 0001, 0002...)

In the absolute majority of cases we are interested in platform_pc and version_10 of each game. However for the sake of documentation other combinations should be considered too, since they do have differences.

@XMDS
Copy link
Member

XMDS commented May 9, 2021

but speaking of CLEO opcodes, for example, there is a difference, since some commands only exist for Android version of the game.

In the original command, Android and IOS are the same. Regarding the new commands of Android CLEO, as mentioned before, we will expand on CLEO. Also, I guess @squ1dd13 will eventually add some new Android commands to ios CLEO.

Also some commands only exist in a particular game version/release. For example,
0482 SET_THREAT_REACTION_RANGE_MULTIPLIER // only work with GTA 3 v1.0, does not work with GTA3 1.1
059C in Vice City have different parameters for US and JP versions.
059A is not a return_false command, but presumably it returns true on the Australian release of the game.

In this sense, for accurate descriptions and covering all possible game releases we have to think about extra dimension for commands grouping in addition to extension and id. Game version?

It is really necessary to distinguish between game versions. However, the 059A in the example determines whether it is an Australian version of the game, even if it is running on the US version, it is normal to return false. This command only returns true in the Australian version. There is not much need for this command to be marked as a regionally released version. Because it can also be used in other versions.

@x87
Copy link
Contributor Author

x87 commented May 9, 2021

GTA III

Platform: PC/PS2 (US/EUR v1.0) - supports 0000 through 0482
Platform: PC v1.1/Steam - does not support 0482=1,set_threat_reaction_range_multiplier
//android/ios - used 03A8, 03A9

Vice City
Platform: PC/PS2 (US,EU,AUS region, both 1.0/1.1) - supports 0000 through 05A8
Platform: PC/PS2 (JP region) - changed 059C and removed 059D through 05A8
Platform: Mobile (android/ios) - added 05a9, 05aa, 05ab, 05ac

San Andreas
v1.0-2.0 (PC/all regions) - supports 0000 through 0A4E
mobile (ios/android) - changed 0242, added 0A4F through 0A8D
remastered (next-gen consoles) - added 0A8E, 0A8F, 0A90

@x87
Copy link
Contributor Author

x87 commented Nov 10, 2021

Added Platform tags

image

Can be either Any or a combination of PC/Mobile/Console (but not all three)

Default value for platforms is Any

@x87
Copy link
Contributor Author

x87 commented Nov 24, 2021

Added version tags (unique for each game), example for San Andreas
Screen Shot 2021-11-24 at 00 51 36

extra versions could be added if there is a need.

game+platform+version should provide a way to describe any possible variation of a command.

@x87 x87 closed this as completed Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants