Set default favicon value to not defined instead of hardcoded

dpgmediamagazines · Dec 18, 2018 · 4458443 · 4458443
1 parent 842dce8
commit 4458443
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/arctic/generics.py b/arctic/generics.py
@@ -183,7 +183,7 @@ def get_site_logo(self):
         return arctic_setting("ARCTIC_SITE_LOGO")
 
     def get_site_favicon(self):
-        return getattr(settings, "ARCTIC_SITE_FAVICON", "/static/favicon.ico")
+        return getattr(settings, "ARCTIC_SITE_FAVICON", None)
 
     def get_site_name(self):
         return arctic_setting("ARCTIC_SITE_NAME")

diff --git a/arctic/templates/arctic/partials/head.html b/arctic/templates/arctic/partials/head.html
@@ -5,7 +5,9 @@
 <meta name="description" content="">
 <meta name="author" content="">
 
-<link rel="shortcut icon" href="{% static SITE_FAVICON %}"/>
+{% if SITE_FAVICON %}
+    <link rel="shortcut icon" href="{% static SITE_FAVICON %}"/>
+{% endif %}
 
 <title>
     {% block title %}