Skip to content

Commit

Permalink
fix flake8
Browse files Browse the repository at this point in the history
  • Loading branch information
aodarc committed Mar 13, 2018
1 parent 1e8ea4f commit 6ea2ee2
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 6 deletions.
14 changes: 11 additions & 3 deletions arctic/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ def __init__(self, *args, **kwargs):
self.fields[self.filters_query_name] = self._get_filter_form_field(
required=False,
choices=self.FILTER_BUTTONS,
widget=self._get_filter_field_widget(attrs={'select_multiple': self.filters_select_multiple})
widget=self._get_filter_field_widget(
attrs={'select_multiple': self.filters_select_multiple}
)
)

def get_quick_filters_field(self):
Expand All @@ -29,12 +31,18 @@ def get_quick_filters_field(self):
@property
def _get_filter_form_field(self):
"""Return form form field according to multiple select possibility"""
return forms.MultipleChoiceField if self.filters_select_multiple else forms.ChoiceField
if self.filters_select_multiple:
return forms.MultipleChoiceField
else:
return forms.ChoiceField

@property
def _get_filter_field_widget(self):
"""Return field widget according to multiple select possibility"""
return QuickFiltersSelectMultiple if self.filters_select_multiple else QuickFiltersSelect
if self.filters_select_multiple:
return QuickFiltersSelectMultiple
else:
return QuickFiltersSelect


class SimpleSearchForm(forms.Form):
Expand Down
6 changes: 4 additions & 2 deletions arctic/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,8 @@ def get_context(self, name, value, attrs=None, *args, **kwargs):
def render(self, name, value, attrs=None):
"""For django 1.10 compatibility"""
if django.VERSION >= (1, 11):
return super(QuickFiltersSelectMixin, self).render(name, value, attrs)
return super(QuickFiltersSelectMixin, self).render(
name, value, attrs)
else:
t = render_to_string(
template_name=self.template_name,
Expand All @@ -132,7 +133,8 @@ class QuickFiltersSelect(QuickFiltersSelectMixin, RadioSelect):
"""


class QuickFiltersSelectMultiple(QuickFiltersSelectMixin, CheckboxSelectMultiple):
class QuickFiltersSelectMultiple(QuickFiltersSelectMixin,
CheckboxSelectMultiple):
"""
This widget is used to be able to have a few active filters
"""
1 change: 0 additions & 1 deletion example/articles/forms.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,3 @@ def get_search_filter(self):
q |= conditions.get(value, Q())

return q | conditions.get(values, Q())

0 comments on commit 6ea2ee2

Please sign in to comment.