Submenu icons display option was added. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think SUBMENU_ICONS_DISPLAY is needed, if no icon is given, then none will be displayed, the icon class parameter is optional, both in menu as in the submenu: |
mmarcos
approved these changes
Mar 14, 2017
mmarcos
added a commit
that referenced
this pull request
Mar 14, 2017
…login-next-check * commit '71c17b24c351f7bab602e186b8e325f41fc16d83': (143 commits) Considerate improved performance; no query per has_permission call #182 (#183) Submenu icons display option was added. (#185) Upgraded jango-extra-views to version 0.9.0 (#181) forgot to remove one reference of django 1.9 removed django 1.9 tests from tox to avoid http 429 ’too many requests’ errors from github dependencies added 10s sleep between tox profiles to avoid github timeouts of dependencies second attempt to fix tox/travis on django 1.10 attempt to fix tox in travis with django 1.10 fixed issue with using dependencies not yet available in PyPI, in this case a version of django-extra-views compatible with django 1.10 flake8 fixes Fixed #164 updated changelog, compiled the latest changes to the frontend tooling Updated changelog format to comply with keepachangelog.com Issue 167, added sub block changed reference from django-extra-views from github master to pypi, since the url schema was breaking tox downgraded django-filter version fixed jango-extra-views url bumped version number to 0.9.4 bumped dependencies versions Build assets Updated bugs in jquery are you sure ...
mmarcos
added a commit
that referenced
this pull request
Mar 17, 2017
* master: bumped version number to 0.9.5 Small bug fix Build assets Feature/login next check (#140) Removed css to fieldset tag, and added class to old fieldset tags Build assets Added fieldset to all forms to meke it easiear disabled them when needed Considerate improved performance; no query per has_permission call #182 (#183) Submenu icons display option was added. (#185) Changed labels for checkboxes in horizontal forms Devided big form field html in smaller chunks Build assets Added block ofr inline field forms Removed style horizontal from create update because horizontal is not the default (the style was being ignored before) removed empty lines Added option to change the size of the collums for horizontal forms (default is 2 for label and 10 for form field) second draft Added first draff of horiontal suport for the forms Added fieldset to forms # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUBMENU_ICONS_DISPLAY was introduced to enable submenu icons display.
If any submenu icon is not provided, items keep aligned by left edge of capital letter.
Example view is shown on screenshot.