Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ability to specify not required parameter for action link. Fixe… #321

Merged
merged 2 commits into from Nov 14, 2018

Conversation

wolendranh
Copy link
Contributor

@wolendranh wolendranh commented Nov 9, 2018

action_link changes and fixes.

Description

Fixed action link title attribute that was broken.
Added ability to specify additional custom attributes for action link.
Updated documentation.

Example case:
Add attribute

target="_blank"

to open link in new tab.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 73.543% when pulling ec3298d on feature/add_custom_action_link_attributes into c6b482a on develop.

@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage decreased (-0.02%) to 73.531% when pulling 8c386d4 on feature/add_custom_action_link_attributes into c6b482a on develop.

Copy link
Contributor

@mmarcos mmarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to support attributes, but it's better to have them inside the third parameter instead of adding a fourth positional parameter which makes things a bit complex, the same idea is already used for formaction, which is sent in the third parameter inside the dictionary and recognised as a special keyword.

So you could do:
(label, url, {"attributes": {attr1: val1, attr2: val2}, ...})

@mmarcos mmarcos merged commit 187e289 into develop Nov 14, 2018
@mmarcos mmarcos deleted the feature/add_custom_action_link_attributes branch February 25, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants