Added ability to select custom class on action links #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VolodiaKhl
requested review from
mmarcos,
Gooliver2,
wolendranh,
aodarc and
jmijn
jmijn
reviewed
Dec 20, 2018
docs/reference.md
Outdated
| @@ -318,7 +318,7 @@ appear on the last column of the table and can apply a certain action, such | |||
| as delete. | |||
| In case if some custom attributes required, they can be specified as last argument in form of dict. In this case | |||
| optional icon class can be provided as part of that argument dict | |||
| `('name', 'base_url', 'optional icon class', {'icon_class': 'fa', 'attributes': {'custom_attr_name': 'custom_attr_value'}})` | |||
| `('name', 'base_url', 'optional icon class', {'icon_class': 'fa', 'action_class': 'name', 'attributes': {'custom_attr_name': 'custom_attr_value'}})` | |||
There was a problem hiding this comment.
If there is already an icon_class, why do we need an action_class? I don't see the icon_class in the code however...
jmijn
reviewed
Dec 20, 2018
mmarcos
reviewed
Dec 20, 2018
mmarcos
reviewed
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to select custom class on action links. It is very helpful if, for example, translations are used