Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong extensionKind for remote session #114

Closed
david-morris opened this issue Feb 21, 2024 · 3 comments · Fixed by #115
Closed

wrong extensionKind for remote session #114

david-morris opened this issue Feb 21, 2024 · 3 comments · Fixed by #115

Comments

@david-morris
Copy link
Contributor

Describe the bug
All commands error out immediately after installing.
image

To Reproduce
Steps to reproduce the behavior:

  1. Install from extensions pane
  2. run an owlbear command from the F1 menu

Expected behavior
Commands execute without error and perform edits

Screenshots
If applicable, add screenshots to help explain your problem.

image

Desktop (please complete the following information):

  • OS: Win 11
  • Browser none/electron
  • Version VSCode 1.84.2 Owlbear 1.1.5

Additional context

when I run a command from a keystroke, that errors out too:
image

I'm using a vscode remote setup with a WSL/Docker dev environment.

I refreshed the window but haven't done a cold start of vscode since installing.

@david-morris david-morris changed the title broken parser immediately after install broken parser in remote session Feb 22, 2024
@david-morris
Copy link
Contributor Author

david-morris commented Feb 22, 2024

I've now been able to do more debugging on this.

Owlbear is working on the base Windows setup, but not when working in Remote Windows for WSL or in the dev container.

So that's an issue with either Remote Windows and Owlbear, or OS compatibility.

Maybe this is going to be something simple like setting whether this extension runs in the host or client of a remote session.

I'll test that when I can, but does anyone here already know whether Owlbear is compatible with Linux?

Edit: from #108 I take it that Owlbear is better tested Unix platforms than windows. I'm guessing that this is a problem with remote access, then.

This extension development doc will probably be useful on this ticket.

The first thing to try would be to set the extension location in the package.json which lines up with my hunch that the wasm is getting loaded onto the wrong node interpreter.

image

@david-morris david-morris changed the title broken parser in remote session wrong extensionKind for remote session Feb 22, 2024
@david-morris
Copy link
Contributor Author

OK, I just used the remote.extensionKind setting to force the extension to run as a UI extension. That worked, so this is probably a single line change to package.json.

@sansarip
Copy link
Owner

OK, I just used the remote.extensionKind setting to force the extension to run as a UI extension. That worked, so this is probably a single line change to package.json.

Thanks for the thoughtful investigation here David, and for putting up a fix! I'll take a look at your PR this evening (EST) 🤘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants