Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request?] Update matchit crate to the most recent version #291

Closed
fregataa opened this issue Oct 9, 2022 · 2 comments
Closed

[Feature Request?] Update matchit crate to the most recent version #291

fregataa opened this issue Oct 9, 2022 · 2 comments

Comments

@fregataa
Copy link

fregataa commented Oct 9, 2022

Current Behavior
Robyn uses matchit crate version 0.4.3 currently, and the most recent version of matchit is 0.6.0 for now 2022 Oct 10th.

Desired Behavior
We do not need to update matchit to "0.6.0" ASAP because it is also under development.
But we will have to update the dependency when the crate is stable.
I checked matchit::Node is replaced with matchit::Router and there can be other updates that I have not found.

Screenshots / Mockups

Alternatives
@sansyrox
Copy link
Member

Perfect. Thanks for the update. I will have a look at the updates.

@suhailmalik07 suhailmalik07 mentioned this issue Oct 28, 2022
Merged
@sansyrox
Copy link
Member

This has been fixed in #298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sansyrox @fregataa