[BUG] Render Template #339

Paroxyste · 2022-12-16T06:33:39Z

Hello to all,

I have installed Robyn, via pip under python 3.10.6 on Mac M1.
I wanted to test the render_template but I have a problem. I copied the code from the doc but it doesn't work.

from robyn import Robyn
from robyn.templating import JinjaTemplate
from pathlib import Path
import os

current_file_path = Path(__file__).parent.resolve()
JINJA_TEMPLATE = JinjaTemplate(os.path.join(current_file_path, "templates"))

app = Robyn(__file__)

@app.get("/template_render")
def template_render():
    context = {
        "framework": "Robyn",
        "templating_engine": "Jinja2"
    }

    template = JINJA_TEMPLATE.render_template(template_name="test.html", **context)
    return template

app.start(port=5000)

{# templates/test.html #}

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>Results</title>
</head>

<body>
  <h1>{{framework}} 🤝 {{templating_engine}}</h1>
</body>
</html>

Jinja does a good job of replacing the values (framework, templating_engine) but the rendering prints the html code in the browser (i use Brave Browser) ...

Do you have any idea where this is coming from?

Thanks

shaohaiyang · 2022-12-16T07:31:44Z

You should be insert a default get router before the template render:

app = Robyn(__file__)

@app.get("/")
@app.get("/template_render")
def template_render():

Paroxyste · 2022-12-16T07:52:06Z

Thank you for your answer, but it remains unchanged.

from robyn import Robyn
from robyn.templating import JinjaTemplate
from pathlib import Path
import os

current_file_path = Path(__file__).parent.resolve()
JINJA_TEMPLATE = JinjaTemplate(os.path.join(current_file_path, "templates"))

app = Robyn(__file__)

@app.get("/")
@app.get("/template_render")
def template_render():
    context = {
        "framework": "Robyn",
        "templating_engine": "Jinja2"
    }

    template = JINJA_TEMPLATE.render_template(template_name="test.html", **context)
    return template

app.start(port=5000)

Now in 127.0.0.1:5000 i've got :

But in 127.0.0.1:5000/render_template i've got white blank page.

shaohaiyang · 2022-12-17T01:36:07Z

It works on my chrome , safari, firefox, even lynx CLI browser when i copy the codes exactly the same. Have you ever tried another browser?

Paroxyste · 2022-12-17T11:41:14Z

I don't understand, I've the same problem with firefox and safari:

What version of python and robyn are you using?

sansyrox · 2022-12-17T11:41:55Z

@Paroxyste , can you please tell me how are you running your code and what is your directory structure?

sansyrox · 2022-12-17T11:42:49Z

@shaohaiyang , this shouldn't be the case. Does it not work without a default route for you?

You should be insert a default get router before the template render:
app = Robyn(file)
@app.get("/")
@app.get("/template_render")
def template_render():

sansyrox · 2022-12-17T11:45:07Z

@Paroxyste , I think I might know your issue. Can you please try running it at a port different from 5000? Maybe 5001?

Lmk if that works and then I might be able to come up with an explanation.

sansyrox · 2022-12-17T11:45:17Z

@Paroxyste , I think I might know your issue. Can you please try running it at a port different from 5000? Maybe 5001?

Lmk if that works and then I might be able to come up with an explanation.

Paroxyste · 2022-12-17T11:49:32Z

I run

python main.py    or    python main.py --dev

My structure code is :

I tried by changing port and html code, but the result is identical

sansyrox · 2022-12-17T11:56:05Z

@Paroxyste , this is a bit strange as I copied everything from your code and It is working for me.

Which version of Robyn are you using?

sansyrox · 2022-12-17T11:57:09Z

Can you please share your main.py too ? I want to make sure that we are not having some unintended mistake there

Paroxyste · 2022-12-17T12:07:26Z

main.py

# -----------------------------------------------------------------------------
# !/usr/bin/python3
# -*- coding: utf-8 -*-
# -----------------------------------------------------------------------------


from pathlib          import Path
from robyn            import Robyn
from robyn.templating import JinjaTemplate

import os

# -----------------------------------------------------------------------------
# APP: APP CONFIG
# -----------------------------------------------------------------------------

current_file_path = Path(__file__).parent.resolve()
JINJA_TEMPLATE = JinjaTemplate(os.path.join(current_file_path, "templates"))


app = Robyn(__file__)

@app.get("/")
@app.get("/template_render")
def template_render():
    context = {
        "framework": "Robyn",
        "templating_engine": "Jinja2"
    }

    template = JINJA_TEMPLATE.render_template(template_name="test.html", **context)
    return template

app.start(port=5001)

sansyrox · 2022-12-17T15:32:05Z

@Paroxyste , can you try running this to see if that works for you

from robyn import Robyn, jsonify
from robyn.templating import JinjaTemplate
from pathlib import Path
import os

current_file_path = Path(__file__).parent.resolve()
JINJA_TEMPLATE = JinjaTemplate(os.path.join(current_file_path, "templates"))

app = Robyn(__file__)

@app.get("/")
def template_render():
    context = {
        "framework": "Robyn",
        "templating_engine": "Jinja2"
    }

    template = JINJA_TEMPLATE.render_template(template_name="test.html", **context)
    return {
        "status": "200",
        "body": template,
        "headers": jsonify({"Content-Type": "text/html"})
    }


if __name__ == "__main__":
    app.start(port=8000)

Paroxyste · 2022-12-17T16:45:19Z

Yes that work fine thanks very much

sansyrox · 2022-12-17T17:18:44Z

Reopening this means that we should return this header by default.

 "headers": jsonify({"Content-Type": "text/html"})

I will create a PR for this.

Paroxyste · 2022-12-17T18:01:38Z

For the jinja implementation would it be possible to add something to load the resources like Flask:

{{ url_for('static', filename='images/planets.jpeg') }}

or Starlette :

{{ url_for('static', path='images/planets.jpeg') }}

or for a route:

{{ url_for('/') }}

Because currently using url_for makes the template crash and returns a 500 error ...

Out put this point the integration of jinja works well good job ;)

sansyrox · 2022-12-20T20:31:02Z

@Paroxyste , sure. I can have a look at this :D

koryca · 2023-06-27T00:37:41Z

We are working on this issue but it looks like it's already solved. I tried to produce the issue and my browser shows no problem with or without "headers": jsonify({"Content-Type": "text/html"})
robyn/templating.py
Is this issue still ongoing?

sansyrox · 2023-12-02T00:04:26Z

This issue was solved but was kept open for Jinja template resource loading. Closing this.

Paroxyste mentioned this issue Dec 17, 2022

[BUG] Get Stared failed on Windows #340

Closed

Paroxyste closed this as completed Dec 17, 2022

sansyrox reopened this Dec 17, 2022

sansyrox added good first issue Good for newcomers CodeDay Labs labels Jun 2, 2023

sansyrox closed this as completed Dec 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Render Template #339

[BUG] Render Template #339

Paroxyste commented Dec 16, 2022

shaohaiyang commented Dec 16, 2022

Paroxyste commented Dec 16, 2022

shaohaiyang commented Dec 17, 2022 •

edited

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022 •

edited

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022 •

edited

Paroxyste commented Dec 17, 2022 •

edited

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 20, 2022

koryca commented Jun 27, 2023 •

edited

sansyrox commented Dec 2, 2023

[BUG] Render Template #339

[BUG] Render Template #339

Comments

Paroxyste commented Dec 16, 2022

shaohaiyang commented Dec 16, 2022

Paroxyste commented Dec 16, 2022

shaohaiyang commented Dec 17, 2022 • edited

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022 • edited

sansyrox commented Dec 17, 2022

sansyrox commented Dec 17, 2022 • edited

Paroxyste commented Dec 17, 2022 • edited

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 17, 2022

Paroxyste commented Dec 17, 2022

sansyrox commented Dec 20, 2022

koryca commented Jun 27, 2023 • edited

sansyrox commented Dec 2, 2023

shaohaiyang commented Dec 17, 2022 •

edited

Paroxyste commented Dec 17, 2022 •

edited

sansyrox commented Dec 17, 2022 •

edited

Paroxyste commented Dec 17, 2022 •

edited

koryca commented Jun 27, 2023 •

edited