-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update rust packages to latest #298
Conversation
✅ Deploy Preview for robyn canceled.
|
let startup_handler = self.startup_handler.clone(); | ||
let shutdown_handler = self.shutdown_handler.clone(); | ||
|
||
let task_locals = Arc::new(pyo3_asyncio::TaskLocals::new(&event_loop).copy_context(py)?); | ||
let task_locals_cleanup = task_locals.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as PyO3 update there APIs to use task_locals instead of event_loop
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suhailmalik07 , this looks great thanks. Can you just point me to the task_locals
documentation too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, In documentation. It's mentioned under solution.
Link: https://docs.rs/pyo3-asyncio/0.17.0/pyo3_asyncio/#the-solution
Here in migration, It's also mentioned (Last point).
This PR addresses #291 also. |
Hey @sansyrox, We can merge this one, if everything looks good to you. |
Cargo.toml
Outdated
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "robyn" | |||
version = "0.18.1" | |||
version = "0.18.1000001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you replace this with 0.18.1
before we can merge the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pyproject.toml
Outdated
@@ -1,5 +1,5 @@ | |||
name = "robyn" | |||
version = "0.18.1" | |||
version = "0.18.1000001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! ❇️ 🚀
* update rust packages to latest * fix clippy issues * fix package version
Description
This PR #291
Updates Rust packages to latest.
Testing
PS: I'm new to rust, if there is anything which can be improved or not correct. Let me know.