update rust packages to latest #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for robyn canceled.
|
suhailmalik07
commented
Oct 28, 2022
| let startup_handler = self.startup_handler.clone(); | ||
| let shutdown_handler = self.shutdown_handler.clone(); | ||
|
|
||
| let task_locals = Arc::new(pyo3_asyncio::TaskLocals::new(&event_loop).copy_context(py)?); | ||
| let task_locals_cleanup = task_locals.clone(); |
There was a problem hiding this comment.
as PyO3 update there APIs to use task_locals instead of event_loop.
There was a problem hiding this comment.
@suhailmalik07 , this looks great thanks. Can you just point me to the task_locals documentation too?
There was a problem hiding this comment.
Sure, In documentation. It's mentioned under solution.
Link: https://docs.rs/pyo3-asyncio/0.17.0/pyo3_asyncio/#the-solution
Here in migration, It's also mentioned (Last point).
|
This PR addresses #291 also. |
|
Hey @sansyrox, We can merge this one, if everything looks good to you. |
sansyrox
reviewed
Oct 30, 2022
Cargo.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "robyn" | |||
| version = "0.18.1" | |||
| version = "0.18.1000001" | |||
There was a problem hiding this comment.
Can you replace this with 0.18.1 before we can merge the PR.
sansyrox
reviewed
Oct 30, 2022
pyproject.toml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name = "robyn" | |||
| version = "0.18.1" | |||
| version = "0.18.1000001" | |||
sansyrox
reviewed
Oct 30, 2022
Shending-Help
pushed a commit
to Shending-Help/robyn
that referenced
this pull request
Nov 3, 2022
* update rust packages to latest * fix clippy issues * fix package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR #291
Updates Rust packages to latest.
Testing
PS: I'm new to rust, if there is anything which can be improved or not correct. Let me know.