-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Windows tests #402
Conversation
✅ Deploy Preview for robyn canceled.
|
ff9cb16
to
a1d6bdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the remaining test for Windows @sansyrox ! I have a few suggestions before we can merge this.
These are great suggestions @AntoineRR 😄 I will implement them tomorrow haven't slept in two days haha 🤣 |
707cc30
to
35ed50b
Compare
get conditional global hosts as windows does not allow 0.0.0.0 host
35ed50b
to
a68d94b
Compare
@AntoineRR , all done! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! The helpers directory is a nice touch, thanks!
get conditional global hosts as windows does not allow 0.0.0.0 host
Description
This PR fixes #372
Fixes test on windows