feat: Implement global CORS #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #458 Summary
Benchmarks breakdown
|
sansyrox
force-pushed
the
main
branch
4 times, most recently
from
f0bf73a
to
97e2c0c
Compare
Before implementing per route CORS, I would like to implement middleware chaining.
for more information, see https://pre-commit.ci
sansyrox
force-pushed
the
feat/cors
branch
4 times, most recently
from
930ca20
to
f860a52
Compare
sansyrox
force-pushed
the
feat/cors
branch
3 times, most recently
from
bb6da24
to
3491ee9
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR partially implements CORS.
I would also like to implement per-route CORS, However, before implementing per route CORS, I would like to implement middleware chaining. This will substantially improve the way we structure our code.