Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth type should be uint instead of int #20

Closed
santisq opened this issue Sep 9, 2023 · 0 comments · Fixed by #24
Closed

Depth type should be uint instead of int #20

santisq opened this issue Sep 9, 2023 · 0 comments · Fixed by #24
Assignees
@santisq
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@santisq
Copy link
Owner

santisq commented Sep 9, 2023 •
edited

Current -Depth parameter:

    [Parameter]
    [ValidateRange(0, int.MaxValue)]
    public int Depth = 3;

Should be changed to:

    [Parameter]
    public uint Depth { get; set; } = 3;

Docs should also be updated to reflect this change.
@santisq santisq self-assigned this Sep 9, 2023
@santisq santisq added enhancement New feature or request documentation Improvements or additions to documentation labels Sep 9, 2023
@santisq santisq linked a pull request Sep 12, 2023 that will close this issue
changing -Depth parameter type from int to uint. updating docs. #24
Merged
@santisq santisq mentioned this issue Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@santisq santisq

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

changing -Depth parameter type from int to uint. updating docs. santisq/PSTree
1 participant
@santisq