Starting work on plotly 3.0.0 migration

[timkpaine]

this is just a first pass, theres some major work to do:

• 2 "FIXME TKP" sections were just commented out in plotlytools
• Docstrings and defaults are wrong in many cases (e.g. "horizontal"/"vertical" not valid, "dot" not a valid marker type)
• 3 "FIXME TKP" sections commented out in quant_figure
• Fix JupyterLab support
  • In plotlytools, replace calls to plot/iplot with return go.FigureWidget(data=figure['data'], layout=figure['layout']), not working currently for QuantFig
  • working on in Have plot and iplot return instance of FigureWidget plotly/plotly.py#1071

[timkpaine]

should probably follow #119 and switch everything to use raw dictionaries until the last step

[timkpaine]

all the examples from the notebooks are working (albeit with warnings, also for latest pandas you need to call .mean() after resample). Need to check quantfigs (I commented out the tests for now)

[timkpaine]

shouldn't need bullet 3 plotly/plotly.py#1071

[timkpaine]

somebody get me a beer

[timkpaine]

this is done, just waiting on the plotly bullet but it should still work

[dhirschfeld]

🍻!

[timkpaine]

plotly bullet is resolve, make sure to install @jupyterlab/plotly-extension in addition to plotlywidget

[dhirschfeld]

Confirmed that this PR works great with nteract:

(previously threw an exception)

[dhirschfeld]

Would love to get this functionality merged!

[dnanhkhoa]

Great, it works 👍 can't wait for merging

[davhin]

The cufflinks version in the pull request from timkpaine works well for me with:

plotly 3.1.0,
jupyterlab 0.34.2

and
jupyter-widgets/jupyterlab-manager v0.37.2
jupyterlab/plotly-extension v0.16.0
plotlywidget v0.2.1

Just trying to add some confidence, not meaning to confirm that it works at all ;)

[santosjorge]

Going through this PR this week. Thank you for the work so far @timkpaine !

[lilcatria]

secondary axis example seem to be breaking ,

plotly 3.1.1

fig=cf.datagen.lines(3,columns=['a','b','c']).figure()
fig=fig.set_axis('b',side='right')
cf.iplot(fig)

AttributeError Traceback (most recent call last)
in ()
1 fig=cf.datagen.lines(3,columns=['a','b','c']).figure()
----> 2 fig=fig.set_axis('b',side='right')
3 cf.iplot(fig)

AttributeError: 'dict' object has no attribute 'set_axis'

[timkpaine]

I'll take a look, there's one other issue I know about that I need to fix

[santosjorge]

alright. here we go.

[timkpaine]

@jonmmease FYI