Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid ChargeBoxID returned in transaction #19

Closed
mehdijouan opened this issue Oct 9, 2018 · 4 comments
Closed

Invalid ChargeBoxID returned in transaction #19

mehdijouan opened this issue Oct 9, 2018 · 4 comments
Labels
bug

Comments

@mehdijouan
Copy link
Contributor

During a transaction, the returned ChargeBoxID is not the same as the one sent. In fact, it is an hexadecimal string representing it.

ChargeBoxID sent JX5HM5JMDHS9 to start a new transaction.
ChargeBoxID received 4a5835484d354a4d44485339 when reading the transaction from the server.
@mehdijouan mehdijouan added the bug label Oct 9, 2018
@mehdijouan
Copy link
Contributor Author

@LucasBrazi06 @lucasbrazi , could you confirm that it is not expected.

@mehdijouan
Copy link
Contributor Author

In Database.js of commit e1d75ac, All ids are validated using the function Database.validateId. I agree regarding internal ids created by the server, but, for the chargeBoxID, as it is provided from outside, it should not be forced to be an hexadecimal string.

@LucasBrazi06
Copy link
Collaborator

Indeed !!!
I'll fix it right away !

@LucasBrazi06
Copy link
Collaborator

Solved in 7c2da08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mehdijouan @LucasBrazi06