Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode - Hybrid Development - UI5 Version 1.111.1 Failure #21

Closed
attilaberencsi opened this issue Mar 11, 2023 · 4 comments
Closed

VSCode - Hybrid Development - UI5 Version 1.111.1 Failure #21

attilaberencsi opened this issue Mar 11, 2023 · 4 comments

Comments

@attilaberencsi
Copy link
Contributor

Dear SuSaaS Team,

following step 2.5 in the hybrid development guide we're facing the following issue.

image

image

This issue happens on UI5 version 1.111.1.

After rebooting the application with the help of UI5 Diagnostics with version 1.108.10 the application loads as expected

image

image

image

I did a trick in default-env.json (I saw it at another place).

image

This resulted to load the application with lower version by default and fixed the issue.

Can we fix this somehow in the GitHub repository as well ? I am not sure this is the best approach to push such, but works.

Thank you in advance

Best regards

Attila

@attilaberencsi attilaberencsi changed the title VSCode - Hybrid Development VSCode - Hybrid Development - UI5 Version 1.111.1 Failure Mar 11, 2023
@martinfrick
Copy link
Contributor

Hi @attilaberencsi,

we appreciate your input and support on keeping the repository up-to-date! I will double-check on this issue tomorrow morning and update the default-env.json accordingly! As you probably noticed, the ui5 destination in the destination service configuration (mta.yaml) is already fixed on 1.108.4.

Thanks again!
Martin

@martinfrick
Copy link
Contributor

Hi @attilaberencsi,

I have recently committed some code and documentation changes. As part of these changes, the version of SAPUI5 is now consistently fixed at 1.108.4, which we used for our testing purposes. Additionally, the UI modules and Application Router now include a local.html file, enabling easy local testing by running cds watch. With these files, there is no need for a ui5 destination as the resource path is fixed. Please feel free to test the changes and provide us with your feedback. We appreciate your efforts and encourage you to keep up the good work!

@alperdedeoglu and @martinfrick

@martinfrick
Copy link
Contributor

Changes can be found in in the following commits (same applies to basic version)

e4550da bcb7037 bcb7037

@attilaberencsi
Copy link
Contributor Author

Thank You Guys again!
This is the most valuable repository for me so far :) !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants