-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS Types for different UI5 versions (Question) #7
Comments
Hi Wouter, you mean types for previous UI5 versions? There is definitely a difference - we have invested quite some time to improve the type definitions and the new ones are for writing UI5 code that uses ES modules. I'm unsure whether we can provide the "new" type definitions also for older UI5 versions. We have also done a lot of fixes/improvements in UI5 itself to make the generated type definitions error-free and "good". We can't downport all those changes. We could look into what happens when we just run the generator on an older version of UI5 and how the result looks. There will be errors, but most of them don't actually prevent the usage of the definition files (those few that do can probably be fixed). So maybe an unsupported one-time drop for select long-term-maintenance releases MIGHT be an option to look into after UI5con, but more than that most probably not. In your second question, you mean the last part of
, right? It should just be It seems like the code transformer uses the class name given here: Probably we should rename the class name here to avoid this odd situation. But one has to take care to avoid name clashes in such a case, e.g. with the sap.m.App control type. Let's keep this issue report open to follow up. Regards |
Thank you Andreas! The reason I'm asking about the different TS types for different UI5 versions is because I found a difference for the "navTo" function. We are using UI5 1.71 which has different params for the "navTo" function: In vscode, this gives me an error on the "navTo" function while I'm using it in the correct way. I guess it wouldn't harm to generate it for each version to cover these kind of differences. Regarding the name, that means that renaming the names in TS without "Controller" would be fine? Kr, Wouter |
Hi, Regards |
Hi all,
I noticed some differences in the TS types for other UI5 versions. Can we generate the types for other versions as well?
One more thing, I noticed that the names of the controllers also contain "Controller" at the end while this is not added in the controllername defined in the view. Does the framework excludes "Controller" when connecting the view to the controller?
Thank you in advance!
Kr, Wouter
The text was updated successfully, but these errors were encountered: