Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RND parser categorizes as a CAT_LITERAL in ULINE length statement #80

Closed
alexlukas opened this issue Jul 27, 2023 · 4 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@alexlukas
Copy link

I found the following error when cleaning up some legacy code of ours:

image

The error log shows the same information:

20230727_144425 , line 5: Parse error in line 5: RND Parser categorizes '65' as a CAT_LITERAL

The problem occurs when I try to clean the following snippet, referencing the length 65 of the ULINE command:

REPORT zi_kw_al_test.

START-OF-SELECTION.

  ULINE AT /(65).

We currently have version 1.4.0 installed, but I did not see a reference to this issue in the release notes.

@jmgrassau jmgrassau added the bug Something isn't working label Jul 27, 2023
@jmgrassau
Copy link
Member

Hi Alex,

thanks very much for reporting this! This is indeed a bug, because apparently, the ABAP cleaner parser does not properly handle /(65) yet. Same for other possible syntax such as /10(65), /(*), /col(**) etc. Will look into this!

Kind regards,
Jörg-Michael

P.S.: and you're right, this hasn't been fixed up to the current version!

@jmgrassau
Copy link
Member

Hi Alex,

this issue is now fixed for the next release.

I also improved the display of all those potential cases, so numeric literals, identifiers, token operators etc. are now colored consistently:

image

Kind regards,
Jörg-Michael

@jmgrassau jmgrassau self-assigned this Jul 27, 2023
@alexlukas
Copy link
Author

Thanks for your quick answer and fix!

jmgrassau added a commit to jmgrassau/abap-cleaner that referenced this issue Jul 31, 2023
@jmgrassau
Copy link
Member

Hi Alex,

this issue should now be fixed with version 1.5.1 which was just released!

Kind regards,
Jörg-Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants