Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Search Input component #121

Closed
InnaAtanasova opened this issue Dec 21, 2018 · 3 comments
Closed

Refactor Search Input component #121

InnaAtanasova opened this issue Dec 21, 2018 · 3 comments
Assignees
@InnaAtanasova
Labels
enhancement New feature or request
Projects
Development

Comments

@InnaAtanasova
Copy link
Contributor

Search component needs refactoring so it can be used in the Shellbar.
@InnaAtanasova InnaAtanasova self-assigned this Dec 21, 2018
@InnaAtanasova InnaAtanasova added this to To do in Development via automation Dec 21, 2018
@aerfio
Copy link
Contributor

aerfio commented Jan 3, 2019 •
edited

Would you consider giving user the possiblity to use onChange props, and option to hide button on right-hand side? It would be quite useful :D

@InnaAtanasova
Copy link
Contributor Author

@aerfio , I opened a PR for discussion here

@CodesOfRa CodesOfRa added the enhancement New feature or request label Jan 4, 2019
@InnaAtanasova
Copy link
Contributor Author

Done!

Development automation moved this from To do to Done Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InnaAtanasova InnaAtanasova

Labels
enhancement New feature or request
Projects
No open projects
Development
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@CodesOfRa @aerfio @InnaAtanasova