Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.3 wants to post an update to all existing ServiceInstances which fails on Audit Log #358

Closed
pre opened this issue Oct 20, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@pre
Copy link

pre commented Oct 20, 2023

We updated from v0.3.6 -> v0.5.3

We don't have any special local configuration for the sap-btp-service-operator.

The updated controller wants to post an update api call to all existing BTP ServiceInstances. This worked on all other services except Audit Log which fails with

status:
  conditions:
  - lastTransitionTime: "2023-10-20T10:49:39Z"
    message: 'ServiceInstance update failed: Status: 400; ErrorMessage: <nil>; Description:
      Updating service is currently not supported operation. Please create a new service
      with the desired updates and bind to it; ResponseError: <nil>'
    observedGeneration: 1
    reason: UpdateFailed
    status: "False"
    type: Succeeded
  - lastTransitionTime: "2022-08-25T07:41:29Z"
    message: ""
    observedGeneration: 1
    reason: Provisioned
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-10-20T10:49:39Z"
    message: 'ServiceInstance update failed: Status: 400; ErrorMessage: <nil>; Description:
      Updating service is currently not supported operation. Please create a new service
      with the desired updates and bind to it; ResponseError: <nil>'
    observedGeneration: 1
    reason: UpdateFailed
    status: "True"
    type: Failed
  hashedSpec: e633c12d7a499d2d935eba9cbf5e9d48
  instanceID: 6cd0e6a4-f3ef-4f5b-9600-bee1c96bfb14
  observedGeneration: 1
  ready: "True"
  tags:
  - auditlog
  - audit log
  - cf

We did not incorporate any changes to these existing ServiceInstance resources prior to updating the sap-btp-service-operator.

However, I can also see from BTP that almost every other service there owned by the btp operator has the Changed On day as today.

Any ideas what could be causing this? We're hesitant to pushing the update to non-development environments (we have many) until we've figured out a way to not get the Audit Log ServiceInstance in UpdateFailed state in each environment.

@kerenlahav
Copy link
Contributor

this is a bug, instance should not be udpated if not changed, will be fixed in the next release

@kerenlahav kerenlahav added the bug Something isn't working label Oct 22, 2023
@pre
Copy link
Author

pre commented Oct 25, 2023

Maybefix? #359

@kerenlahav
Copy link
Contributor

yes this is the fix, will be released tomorrow

@kerenlahav
Copy link
Contributor

resolved
https://github.com/SAP/sap-btp-service-operator/releases/tag/v0.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants