Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(horizon): radio button border-style resolved to none #10

Closed
platon-rov opened this issue Apr 25, 2022 · 1 comment
Closed

bug(horizon): radio button border-style resolved to none #10

platon-rov opened this issue Apr 25, 2022 · 1 comment

Comments

@platon-rov
Copy link

platon-rov commented Apr 25, 2022

Description

The next variables resolved to none in horizon evening/morning themes:

  • sapField_WarningBorderStyle
  • sapField_InvalidBorderStyle
  • sapField_SuccessBorderStyle
  • sapField_InformationBorderStyle

That leads to the missing border of the radio button circle

image

Version

11.1.38

@dominikschreiber
Copy link
Contributor

It was a deliberate decision by SAP Design to set those sapField_*BorderStyle parameters to none in Horizon (introduced with theming-base-content@11.1.36).

This is intended to work with the sapField_*BackgroundStyle parameters to make it possible to switch between bottom-borders (in Horizon) and four-sided borders (in all other themes). I've described the mechanism in Switchable forders for fields with the 11.1.36 theming-base-content.

The guidance by SAP Design is to use the sapField_*BorderStyle parameters only in combination with the sapField_*BackgroundStyle parameters, and to hard-code the border style (e.g. solid) in all other cases (especially for CheckBoxes and RadioButtons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants