Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons not centered vertically #16

Closed
nbblum opened this issue May 16, 2023 · 4 comments
Closed

Icons not centered vertically #16

nbblum opened this issue May 16, 2023 · 4 comments

Comments

@nbblum
Copy link

nbblum commented May 16, 2023

The .sap-icon--arrow-right and arrow-left and some other icons are not vertically centered which results to problems when trying to align them with other ui elements
image

here is a basic example:
https://plnkr.co/edit/kAUolEPWMg1lRU4S?open=lib%2Fscript.js&preview
image

This could be a duplicate of SAP/fundamental-styles#4532 I'm not sure which repository is the correct one for this issue

@dominikschreiber
Copy link
Contributor

Hi @nbblum! Thank you for bringing that up. I'll take this observation to our icon designers and get back to you.

@nbblum
Copy link
Author

nbblum commented Jul 4, 2023

@dominikschreiber any updates regarding this? Can we somehow help?

@nbblum
Copy link
Author

nbblum commented Jul 5, 2023

With the lastest version (theming-base-content@11.5.0) the arrows are now aligned
image

https://plnkr.co/edit/kAUolEPWMg1lRU4S

@nbblum nbblum closed this as completed Jul 5, 2023
@dominikschreiber
Copy link
Contributor

Hey @nbblum, sorry for my late answer… I'm still on parental leave. Glad that you figured out that 11.5.0 fixed the issue yourselves 😀. All the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants