Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizon focus color #17

Closed
aflalves opened this issue Jun 8, 2023 · 1 comment
Closed

Horizon focus color #17

aflalves opened this issue Jun 8, 2023 · 1 comment

Comments

@aflalves
Copy link

aflalves commented Jun 8, 2023 •
edited
Loading

Hello,

We've noticed that the Horizon Focus Color is not matching when compared to the Design System specification.

Design system says #0032A5 for --sapContent_FocusColor (https://wiki.one.int.sap/wiki/pages/viewpage.action?pageId=2650676579)
But in content/Base/baseLib/sap_horizon/variables.json we have "sapContent_FocusColor": "#0070f2"

Is this expect or is there really a mismatch?
@dominikschreiber
Copy link
Contributor

Hi @aflalves! The design system you're citing is from the SAP-internal wiki, but this is the open-source theming-base-content, so not everyone may be able to follow your argument. Let's just say this is intended. I'll ping you SAP-internally with more details.

@dominikschreiber dominikschreiber closed this as not planned Won't fix, can't repro, duplicate, stale Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominikschreiber @aflalves